nicko 2004/12/19 11:21:55
Modified: src/Appender AdoNetAppender.cs
Log:
Updates suggested by FxCop.
Minor naming changes to internal types.
Perf improvements to type check + type cast code.
Revision Changes Path
1.9 +27 -13 logging-log4net/src/Appender/AdoNetAppender.cs
Index: AdoNetAppender.cs
===================================================================
RCS file: /home/cvs/logging-log4net/src/Appender/AdoNetAppender.cs,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -r1.8 -r1.9
--- AdoNetAppender.cs 22 Nov 2004 02:09:06 -0000 1.8
+++ AdoNetAppender.cs 19 Dec 2004 19:21:55 -0000 1.9
@@ -486,9 +486,11 @@
/// <param name="dbTran">The transaction that the events will
be executed under.</param>
/// <param name="events">The array of events to insert into the
database.</param>
/// <remarks>
+ /// <para>
/// The transaction argument can be <c>null</c> if the appender
has been
/// configured not to use transactions. See <see
cref="UseTransactions"/>
/// property for more information.
+ /// </para>
/// </remarks>
virtual protected void SendBuffer(IDbTransaction dbTran,
LoggingEvent[] events)
{
@@ -712,6 +714,31 @@
#endregion // Protected Instance Methods
+ #region Protected Instance Fields
+
+ /// <summary>
+ /// Flag to indicate if we are using a command object
+ /// </summary>
+ /// <remarks>
+ /// <para>
+ /// Set to <c>true</c> when the appender is to use a prepared
+ /// statement or stored procedure to insert into the database.
+ /// </para>
+ /// </remarks>
+ protected bool m_usePreparedCommand;
+
+ /// <summary>
+ /// The list of <see cref="AdoNetAppenderParameter"/> objects.
+ /// </summary>
+ /// <remarks>
+ /// <para>
+ /// The list of <see cref="AdoNetAppenderParameter"/> objects.
+ /// </para>
+ /// </remarks>
+ protected ArrayList m_parameters;
+
+ #endregion // Protected Instance Fields
+
#region Private Instance Fields
/// <summary>
@@ -731,11 +758,6 @@
private IDbCommand m_dbCommand;
/// <summary>
- /// Flag to indicate if we are using a command object
- /// </summary>
- private bool m_usePreparedCommand;
-
- /// <summary>
/// Database connection string.
/// </summary>
private string m_connectionString;
@@ -759,14 +781,6 @@
/// Indicates whether to use transactions when writing to the
database.
/// </summary>
private bool m_useTransactions;
-
- /// <summary>
- /// The list of <see cref="AdoNetAppenderParameter"/> objects.
- /// </summary>
- /// <remarks>
- /// The list of <see cref="AdoNetAppenderParameter"/> objects.
- /// </remarks>
- private ArrayList m_parameters;
#endregion // Private Instance Fields
}
