I was going to do it but I still can't resolve the issues I'm having with locked files. I'll run the tests on another computer this weekend and see if its just my laptop that is having difficulties. I think NUnit 2.2.3.0 has a new StringAssert class. I think we need to stick to the basic Assert.AreEqual methods so we still support the 2.2.0.0. It looks like 2.2.3.0 was released earilier this month so I doubt everyone has upgraded to it yet.
If someone doesn't upgrade it by this weekend, I'll start doing it. I think its just a find/replace. - Ron ----- Original Message ---- From: Nicko Cadell <[EMAIL PROTECTED]> To: Log4NET Dev <[email protected]> Sent: Thursday, December 15, 2005 3:50:55 AM Subject: RE: PatternLayoutTest sometimes passes, sometimes fails Yes I have run the tests with NUnit GUI 2.1 and all tests pass. It looks like I am slightly down-level on the nunit.framework.dll (still using 2.1.4.0) I will try upgrading to the latest version 2.2.3.0 and testing again. Do you want to go through the tests and update them to use the non deprecated APIs, or do you want me to do that? Nicko > -----Original Message----- > From: Ron Grabowski [mailto:[EMAIL PROTECTED] > Sent: 14 December 2005 22:27 > To: Log4NET Dev > Subject: Re: PatternLayoutTest sometimes passes, sometimes fails > > It appears to run ok when I run the tests using nunit-console.exe: > > http://www.ronosaurus.com/log4net/2005-12-14_nunit_console.png > > I made sure the test.log file did not exist then ran the test > cases using NUnit-gui.exe. > This line from TestExclusiveLockFails causes the first > exception (in NUnit-gui.exe): > > FileStream fs = new FileStream( > filename,FileMode.Create,FileAccess.Write,FileShare.None); > > The file gets created but is zero bytes. The test case also > fail when the file is located at c:\test.log. > > I updated my SVN before after I re-ran my tests. > NUnit-gui.exe still fails. > > Are you able to run the test cases with NUnit-gui.exe? > > > ----- Original Message ---- > From: Nicko Cadell <[EMAIL PROTECTED]> > To: Log4NET Dev <[email protected]> > Sent: Wednesday, December 14, 2005 12:06:24 PM > Subject: RE: PatternLayoutTest sometimes passes, sometimes fails > > > > > -----Original Message----- > > From: Ron Grabowski [mailto:[EMAIL PROTECTED] > > Sent: 14 December 2005 19:46 > > To: [email protected] > > Subject: PatternLayoutTest sometimes passes, sometimes fails > > > > Is there any particular reason why we're still using the > depreciated > > Assertion class in the unit tests? > > No good reason, just none has got round to updating them. > > > > > When run the entire test suite, 2 of the PatternLayoutTests fail: > > > > > > > http://www.ronosaurus.com/log4net/2005-12-14_PatternLayoutTestFail.png > > > > When I run just the PatternLayoutTests, everything is ok: > > > > > > > http://www.ronosaurus.com/log4net/2005-12-14_PatternLayoutTestPass.png > > > > Can anyone else reproduce this? The pass/fail cases occured > before I > > commited my patch this morning. I don't know why the Appender tests > > are failing either. > > When I run the full suite of test they all pass. I am running > against the current SVN head. Is the failure repeatable on > your system now? > > Cheers, > > Nicko > > > >
