Ron, instead of doing all those case insensitive comparisons, I think that it is safe to do a single conversion of the Option to lower case, then do case sensitive comparisons, or even better use a switch block.
Cheers, Nicko > -----Original Message----- > From: Ron Grabowski (JIRA) [mailto:[EMAIL PROTECTED] > Sent: 28 July 2006 05:27 > To: [email protected] > Subject: [jira] Updated: (LOG4NET-77) A small improvement of > log4net.Layout.Pattern.ExceptionPatternConverter - added > 'Option' propery support > > [ http://issues.apache.org/jira/browse/LOG4NET-77?page=all ] > > Ron Grabowski updated LOG4NET-77: > --------------------------------- > > Attachment: ExceptionPatternConverter-WithOptionSupport.cs.patch > > I think its ok to just support just the 5 public properties > on the Exception object. > > > A small improvement of > > log4net.Layout.Pattern.ExceptionPatternConverter - added 'Option' > > propery support > > > ---------------------------------------------------------------------- > > ----------------------------------- > > > > Key: LOG4NET-77 > > URL: http://issues.apache.org/jira/browse/LOG4NET-77 > > Project: Log4net > > Issue Type: Improvement > > Affects Versions: 1.2.10 > > Reporter: Imrich Olha > > Assigned To: Ron Grabowski > > Priority: Minor > > Attachments: > > ExceptionPatternConverter-WithOptionSupport.cs.patch, > > ExceptionPatternConverter.cs > > > > > > A small improvement of > > log4net.Layout.Pattern.ExceptionPatternConverter - added > 'Option' propery support Example of usage: > > <appender name="ConsoleAppender" > type="log4net.Appender.ConsoleAppender" > > > <layout type="log4net.Layout.PatternLayout"> > > <conversionPattern value="%exception{TargetSite} - > %exception{Message}%newline" /> > > </layout> > > </appender> > > -- > This message is automatically generated by JIRA. > - > If you think it was sent incorrectly contact one of the > administrators: > http://issues.apache.org/jira/secure/Administrators.jspa > - > For more information on JIRA, see: > http://www.atlassian.com/software/jira > > > >
