[ http://issues.apache.org/jira/browse/LOG4NET-87?page=comments#action_12424682 ] Nicko Cadell commented on LOG4NET-87: -------------------------------------
Gert, I think these patterns are a very god idea. I have a few suggestions on how to polish them up for release: The copyright year in the file header should reflect the years when the file contents is edited, i.e. for the new files it should be 2006. All classes and methods should have user level comments. See other pattern files for examples. The new patterns added to the PatternLayout should be documented in detail in the PatternLayout <remarks> section. Is there any reason why you have not added a pattern for the AspNetSessionPatternConverter? aspnet-session? The System.Web library isn't available on all platforms, you will need to exclude your new patterns from the build, and from the PatternLayout: // .NET Compact Framework 1.0 has no support for ASP.NET // SSCLI 1.0 has no support for ASP.NET #if !NETCF && !SSCLI > Support ASP.Net related PatternConverters to allow items from the > HttpContext.Current.Session, Cache, Request, etc. to be captured. > ----------------------------------------------------------------------------------------------------------------------------------- > > Key: LOG4NET-87 > URL: http://issues.apache.org/jira/browse/LOG4NET-87 > Project: Log4net > Issue Type: Wish > Components: Core > Affects Versions: 1.2.11 > Reporter: Ron Grabowski > Assigned To: Ron Grabowski > Priority: Minor > > It would be nice if there were built-in Pattern Converters to support core > ASP.Net objects: > %aspnet-session{UserId} > %aspnet-session > %aspnet-request{ProductId} > This issue may be a good time to investigate supporting a more advanced > syntax for the Option parameter: > %aspnet-request{queryString:ProductId} > that could be shared across all Pattern Converters. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
