Thanks, I realize that it is not your job to tutor me in open source development tools, but .... I just tried to do what you said to apply the patch and TortoiseSVN told me the file was not a working copy. Do I need to set TortoiseSVN to point to a server somewhere site or something like that?? (In other words can TortoiseSVN act as a standalone client or must it always talk to a server?)
Many thanks ------------------------------------------------------------------------ ---------- Roy Chastain -----Original Message----- From: Ron Grabowski [mailto:[EMAIL PROTECTED] Sent: Sunday, October 12, 2008 14:25 To: Log4NET Dev Subject: Re: LOG4NET-64 If you put the .patch file in the same directory as RollingFileAppender and right-click on it then navigate to: TortoiseSVN -> Apply patch... You'll view the patch as a diff. There will be a modal window with a title of File Patches. If you right click the patch in that window you'll have the option to Patch All. Selecting that will apply the patch. Maybe there's an easier svn.exe option but I've always used TortoiseSVN to apply patches. If you'd like to contribute code make an issue in JIRA so everyone can comment on it. If its a small change (less than 10 lines) you can probably just copy and paste the code into the ticket. If its longer you need to create a patch file and upload that (don't forget to mark it as being ok to include in Apache projects!). ----- Original Message ---- From: Roy Chastain <[EMAIL PROTECTED]> To: Log4NET Dev <[email protected]> Sent: Sunday, October 12, 2008 2:14:33 PM Subject: LOG4NET-64 I am glad that there is some active work on this patch. Can someone PLEASE tell me how to interpret the .PATCH file so that I can apply the code to my copy of log4Net. Also, I have some code that I would like to give back to the project, but I have no idea how to go about it. Thanks ------------------------------------------------------------------------ ---------- Roy Chastain -----Original Message----- From: Ron Grabowski (JIRA) [mailto:[EMAIL PROTECTED] Sent: Sunday, October 12, 2008 13:37 To: Roy Chastain Subject: [jira] Issue Comment Edited: (LOG4NET-64) [PATCH] to RollingFileAppender.cs to add the ability to preserve the log file name extension when rolling the log file. [ https://issues.apache.org/jira/browse/LOG4NET-64?page=com.atlassian.jira .plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638872 #action_12638872 ] ron edited comment on LOG4NET-64 at 10/12/08 10:36 AM: ----------------------------------------------------------------- My uploaded patch also fixes the issue when the filename is absolute like "c:\\log.txt". The first two patches would write to the file correctly but would incorrectly place the rolled files in the \bin directory of the running program. was (Author: ron): My uploaded patch also fixes fixes the issue when the filename is absolute like "c:\\log.txt". The first two patches would write to the file correctly but would incorrectly place the rolled files in the \bin directory of the running program. > [PATCH] to RollingFileAppender.cs to add the ability to preserve the log file name extension when rolling the log file. > ------------------------------------------------------------------------ ----------------------------------------------- > > Key: LOG4NET-64 > URL: https://issues.apache.org/jira/browse/LOG4NET-64 > Project: Log4net > Issue Type: New Feature > Components: Appenders > Affects Versions: 1.2.9 > Reporter: Joshua Bassett > Assignee: Ron Grabowski > Attachments: LOG4NET-64.patch, LOG4NET-64.patch, patch.txt > > > Normally, when the log file is rolled the file name extension is not preserved. > For example, file.log is rolled to file.log.1 or file.log.yyyy-MM-dd. > However, this may not be desired in all cases and it may be necessary to preserve the log file name extension when the log file is rolled. Most notably, this feature is useful for maintaining file associations under Windows so that all log files can be associated with a particaular text viewer. > For example, file.log is rolled to file.1.log or file.yyyy-MM-dd.log. > This patch adds an additional boolean property PreserveLogFileNameExtension to the RollingFileAppender class which is used to toggle this behavior. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
