[
https://issues.apache.org/jira/browse/LOG4NET-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716685#action_12716685
]
Joshua Masek commented on LOG4NET-27:
-------------------------------------
I made the change for myself so that I could have the functionality now. I
tried to keep the change compatible with the other options:
- I started with the RollingFileAppender.cs.patch
- I moved the logic into RollOverTime
- I created a new property: MaxDateRollBackups
- I made sure it deleted log files with combination of date and rolled by size
- I don't delete files where the filename doesn't match the last modified
timestamp or the previous check timestamp prior to the last modified timestamp.
This was so that it would not delete files like
logfile.txt2005-07-22.txt.1.keepThisForFutureReference
- I made sure it works for when staticLogFileName is true or false
- I'm attaching my version of the RollingFileAppender.cs file. It was based of
the v1.2.10.0 build.
> Rolling files on date/time boundaries doesn't support a maximum number of
> backup files.
> ---------------------------------------------------------------------------------------
>
> Key: LOG4NET-27
> URL: https://issues.apache.org/jira/browse/LOG4NET-27
> Project: Log4net
> Issue Type: New Feature
> Components: Appenders
> Affects Versions: 1.2.11
> Reporter: Florian Ramillien
> Priority: Minor
> Fix For: 1.2.11
>
> Attachments: RollingFileAppender.cs, RollingFileAppender.cs.patch,
> RollingFileAppender.patch
>
>
> A maximum of backup files exist when rolling files on file size, but not for
> rolling on date/time.
> This can be implemented with the same config key : MaxSizeRollBackups
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
