[ https://issues.apache.org/jira/browse/LOG4NET-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781212#action_12781212 ]
Petr Felzmann edited comment on LOG4NET-27 at 11/22/09 8:41 PM: ---------------------------------------------------------------- I created patch from Joshua Masek changes against the current revision in source control. Hope it moves this issue little bit forward. Personaly I'm still on the way to understand the code to be able implement ideas from Ron's comment (05/Jun/09 10:28). Also I'm very supprised how the unit tests are complicated. I'd like to write unit tests for this change... but there are missing completely unit tests for anything concerning date/time :-( was (Author: felzmann): This is patch created from last attachment posted by Joshua Masek. > Rolling files on date/time boundaries doesn't support a maximum number of > backup files. > --------------------------------------------------------------------------------------- > > Key: LOG4NET-27 > URL: https://issues.apache.org/jira/browse/LOG4NET-27 > Project: Log4net > Issue Type: New Feature > Components: Appenders > Affects Versions: 1.2.11 > Reporter: Florian Ramillien > Priority: Minor > Fix For: 1.2.11 > > Attachments: LOG4NET-27.patch, RollingFileAppender.cs, > RollingFileAppender.cs.patch, RollingFileAppender.patch > > > A maximum of backup files exist when rolling files on file size, but not for > rolling on date/time. > This can be implemented with the same config key : MaxSizeRollBackups -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.