On 2011-09-14, Ron Grabowski wrote: > The signature changes from void to ICollection shouldn't break > anything.
I agree. > Now the configurators return a list of configuration messages. I > suppose it should return an array of a certain type instead of just > ICollection. Maybe something like ConfigurationMessage[] or > LogLog[]. I lean more towards ConfigurationMessage[] This is really returning a list of LogLog instances? We should at least introduce some sort of interface IMHO. And I'd prefer (a generic if we had 2.0) IEnumerable as return value. I don't think I like this usage of LogLog at all. I guess you are thinking the same and this is what you were getting at with returning ConfigurationMessage. > ...LogLog sounds like it came from the Department of Redundancy > Department. log4j - we can easily blame them for everything 8-) > Calls to LogLog are now required to pass in the Type of the caller > which replaced inconsistent string identifiers to identify the source > of internal log messages. Yes. Given we are now handing out LogLog instances via a public API I don't view it an internal class anymore, but still don't consider its logging API part of log4net's public surface. So I'm not concerned about the logging methods but about the return value of Configure. Stefan
