On 2011-10-01, Dominik Psenner wrote:

> Hi Stefan,

>> The coming weekend - including the German holiday on Monday - is going
>> to be quite hectic (two birthdays in the family and a "Polterabend"[1]
>> in the neighborhood) for me.  I don't expect to find time looking over
>> your code until next week.  But I promise I'll do.

> <OT>
> Don't forget the "böllern"

Fortunately we don't do that in the lower rhine area 8-)

> </OT>

> Reviewing it all could become quite difficult since this is a huge
> patch. The most effective review method I know is mailing the patch and
> comment parts of it inline.

We have a ReviewBoard instance running at https://reviews.apache.org/
and I've just asked to have a group added for log4net.

I've never used ReviewBoard before but the described pre-commit workflow
sounds as if it was exactly what you described with the email based
workflow.

Stefan

Reply via email to