[ https://issues.apache.org/jira/browse/LOG4NET-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13553821#comment-13553821 ]
Dominik Psenner edited comment on LOG4NET-27 at 1/15/13 1:58 PM: ----------------------------------------------------------------- Hey Spamme. I'm glad to see some new name around here. Doesn't your code snippet remove also recent files? Example: let m_maxSizeRollBackups=30 and assume the application rolled exactly 30 seconds ago. Then your snippet would would remove the file, even though there are only 2 logfiles, wouldn't it? I believe the rolling code should find existing files that have been rolled over and remove the oldest ones until their count is below m_maxSizeRollBackups. Cheers was (Author: nachbarslumpi): Hey Spamme. I'm glad to see some new name around here. Doesn't your code snippet remove also recent files? Example: let m_maxSizeRollBackups=30 and assume the application rolled exactly 30 seconds ago. Then that file would be removed, even though there might be only 2 logfiles, wouldn't it? I believe the rolling code should find existing files that have been rolled over and remove the oldest ones until their count is below m_maxSizeRollBackups. Cheers > Rolling files on date/time boundaries doesn't support a maximum number of > backup files. > --------------------------------------------------------------------------------------- > > Key: LOG4NET-27 > URL: https://issues.apache.org/jira/browse/LOG4NET-27 > Project: Log4net > Issue Type: New Feature > Components: Appenders > Affects Versions: 1.2.11 > Reporter: Florian Ramillien > Priority: Minor > Fix For: 1.2 Maintenance Release > > Attachments: LOG4NET-27.patch, RollingFileAppender.cs, > RollingFileAppender.cs, RollingFileAppender.cs, RollingFileAppender.cs.patch, > RollingFileAppender.patch > > > A maximum of backup files exist when rolling files on file size, but not for > rolling on date/time. > This can be implemented with the same config key : MaxSizeRollBackups -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira