[ 
https://issues.apache.org/jira/browse/LOG4NET-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13737975#comment-13737975
 ] 

Piotr Westfalewicz commented on LOG4NET-388:
--------------------------------------------

Right, I forgot about version compliance.

Generating dynamic assembly in previous version of .NET using CodeDom seems to 
be overengineering therefore I propose either delete the test or make it 
compilable after .NET 3.5 using #if compiler directive.

IMHO adding a comment in the patch with a link to MSDN is enough in this case.

Please tell me what do you think and I'll prepare a patch.
                
> [PATCH] NotSupportedException is thrown in SystemInfo.AssemblyLocationInfo 
> for dynamic assemblies
> -------------------------------------------------------------------------------------------------
>
>                 Key: LOG4NET-388
>                 URL: https://issues.apache.org/jira/browse/LOG4NET-388
>             Project: Log4net
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.2.11
>            Reporter: Piotr Westfalewicz
>            Priority: Minor
>              Labels: easyfix, patch
>         Attachments: NotSupportedExceptionInSystemInfo.patch
>
>
> For dynamic assemblies "Location" property shouldn't be used 
> (http://msdn.microsoft.com/en-us/library/system.reflection.assembly.location.aspx).
> Therefore in log4net.Util.SystemInfo we can test if assembly is dynamic and 
> in result avoid exception.
> Exception is very annoying and popular with NHibernate 3.3.3.4001.
> I have added both fix and test.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to