[
https://issues.apache.org/jira/browse/LOG4NET-484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14978276#comment-14978276
]
NN commented on LOG4NET-484:
----------------------------
Can you accept my patch ?
> System.ObjectDisposedException with FileAppender+InterProcessLock
> -----------------------------------------------------------------
>
> Key: LOG4NET-484
> URL: https://issues.apache.org/jira/browse/LOG4NET-484
> Project: Log4net
> Issue Type: Bug
> Components: Appenders
> Affects Versions: 1.2.13, 1.2.14, 1.2.15, 1.3.0
> Reporter: NN
> Priority: Blocker
> Attachments: LOG4NET-484-1.3.patch, LOG4NET-484.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Configure lockingModel for InterProcessLock with RollingFileAppender.
> {code:xml|title=app.config}
> <?xml version="1.0" encoding="utf-8"?>
> <configuration>
> <configSections>
> <section name="log4net"
> type="log4net.Config.Log4NetConfigurationSectionHandler, log4net" />
> </configSections>
> <log4net>
> <appender name="RollingFileAppender"
> type="log4net.Appender.RollingFileAppender">
> <file type="log4net.Util.PatternString"
> value="test.log" />
> <encoding value="utf-8" />
> <appendToFile value="true"/>
> <rollingStyle value="Size"/>
> <maxSizeRollBackups value="10"/>
> <maximumFileSize value="1"/>
> <staticLogFileName value="true"/>
> <layout type="log4net.Layout.PatternLayout">
> <conversionPattern value="%d [%t] %-5p %c{2} -
> %m%n"/>
> </layout>
> <lockingModel
> type="log4net.Appender.FileAppender+InterProcessLock" />
> </appender>
> <root>
> <level value="INFO"/>
> <appender-ref ref="RollingFileAppender"/>
> </root>
> </log4net>
> </configuration>
> {code}
> Make a log with roll :
> {code:title=Program.cs}
> using log4net;
> namespace ConsoleApplication131
> {
> class Program
> {
> static void Main(string[] args)
> {
> var log = LogManager.GetLogger(typeof(Program));
> log.Info("A");
> log.Info("A");
> }
> }
> }
> {code}
> You get this one roll:
> {noformat}
> log4net:ERROR Failed to Close appender [RollingFileAppender]
> System.ObjectDisposedException: Safe handle has been closed
> at System.Threading.WaitHandle.WaitOneNative(SafeWaitHandle waitHandle,
> UInt32 millisecondsTimeout, Boolean hasThreadAffinity, Boolean exitContext)
> at System.Threading.WaitHandle.WaitOne(Int64 timeout, Boolean exitContext)
> at log4net.Appender.FileAppender.InterProcessLock.AcquireLock()
> at log4net.Appender.FileAppender.LockingStream.AcquireLock()
> at log4net.Appender.FileAppender.WriteFooter()
> at log4net.Appender.TextWriterAppender.WriteFooterAndCloseWriter()
> at log4net.Appender.TextWriterAppender.Reset()
> at log4net.Appender.FileAppender.Reset()
> at log4net.Appender.TextWriterAppender.OnClose()
> at log4net.Appender.AppenderSkeleton.Close()
> at log4net.Util.AppenderAttachedImpl.RemoveAllAppenders()
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
