[ 
https://issues.apache.org/jira/browse/LOG4NET-507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gavan Smith updated LOG4NET-507:
--------------------------------
    Description: 
I wanted to utilize a custom lossyEvaluator to send all buffered events using 
the smtpappender when the discarded event indicated all events in the buffer 
were recent.

A minor change to the documentation would resolve confusion without breaking 
those who rely on only sending the discarded event.  No good for my use case, 
I'll find another way.

If the current behavior is corrected, perhaps change the 
BufferingAppenderSkeleton.cs (approx line 194 .. 198) LossyEvaluator 
documentation to:
                /// <para>
                /// The evaluator will be called for each event that is 
discarded from this 
                /// appender. If the evaluator triggers then the discarded 
event will immediately 
                /// be sent (see <see cref="M:SendBuffer(new LoggingEvent[] { 
discardedLoggingEvent })"/>).
                /// </para>


  was:
I wanted to utilize a custom lossyEvaluator to send all buffered events using 
the smtpappender when the discarded event indicated all events in the buffer 
were recent.

A minor change to the documentation would resolve confusion without breaking 
those who rely on only sending the discarded event.  No good for my use case, 
I'll find another way.

If the current behavior is corrected, perhaps change the 
BufferingAppenderSkelton.cs (approx line 194 .. 198) LossyEvaluator 
documentation to:
                /// <para>
                /// The evaluator will be called for each event that is 
discarded from this 
                /// appender. If the evaluator triggers then the discarded 
event will immediately 
                /// be sent (see <see cref="M:SendBuffer(new LoggingEvent[] { 
discardedLoggingEvent })"/>).
                /// </para>



> The BufferingAppenderSkeleton LossyEvaluator sends  the discarded event not 
> current buffer as documented
> --------------------------------------------------------------------------------------------------------
>
>                 Key: LOG4NET-507
>                 URL: https://issues.apache.org/jira/browse/LOG4NET-507
>             Project: Log4net
>          Issue Type: Bug
>          Components: Appenders
>    Affects Versions: 1.2.15
>            Reporter: Gavan Smith
>            Priority: Minor
>
> I wanted to utilize a custom lossyEvaluator to send all buffered events using 
> the smtpappender when the discarded event indicated all events in the buffer 
> were recent.
> A minor change to the documentation would resolve confusion without breaking 
> those who rely on only sending the discarded event.  No good for my use case, 
> I'll find another way.
> If the current behavior is corrected, perhaps change the 
> BufferingAppenderSkeleton.cs (approx line 194 .. 198) LossyEvaluator 
> documentation to:
>               /// <para>
>               /// The evaluator will be called for each event that is 
> discarded from this 
>               /// appender. If the evaluator triggers then the discarded 
> event will immediately 
>               /// be sent (see <see cref="M:SendBuffer(new LoggingEvent[] { 
> discardedLoggingEvent })"/>).
>               /// </para>



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to