Hi again, Thanks Manuel for sharing your information and filing an issue against it. Would you like to volunteer and try to patch the nant build process to build optimized assemblies?
Cheers 2016-03-16 8:58 GMT+01:00 Pallier, Manuel / BEKO Graz < manuel.pall...@beko.at>: > I’ve now summarized my findings in > https://issues.apache.org/jira/browse/LOG4NET-508 > > > > > > *Von:* Pallier, Manuel / BEKO Graz > *Gesendet:* Montag, 7. März 2016 13:16 > *An:* Log4NET Dev <log4net-dev@logging.apache.org> > *Betreff:* AW: AW: 'DisableOptimizations' flag present in release builds > > > > No, the flag didn't cause any problems. I just noticed it because I > routinely check all the assemblies in my solution with a tool that checks > build and debug options, dependencies, target framework and so on. > > I didn't check it, but I assume a build from within Visual Studio doesn't > have that DisableOptimizations flag, right? So maybe it's only a problem in > the NAnt build files? Does a NAnt build even use the optimize configuration > from the project file? > > > ------------------------------ > > *Von:* Dominik Psenner [dpsen...@gmail.com] > *Gesendet:* Montag, 7. März 2016 10:49 > *An:* log4net-dev@logging.apache.org > *Betreff:* Re: AW: 'DisableOptimizations' flag present in release builds > > The Optimize flag is set to true for the Release build configurations and > set to false for Debug build configurations. *hmm* It could be that a Debug > binary was released in error, but that's just a wild guess. > > How did you come across this? Does the non-optimized debug assembly cause > problems? > > On 2016-03-07 08:41, Pallier, Manuel / BEKO Graz wrote: > > I've used the RedGate .NET Reflector, but the free ILSpy should show it > too. > > > ------------------------------ > > *Von:* Dominik Psenner [dpsen...@gmail.com] > *Gesendet:* Freitag, 4. März 2016 16:36 > *An:* Log4NET Dev > *Betreff:* Re: 'DisableOptimizations' flag present in release builds > > Hi Manuel, > > I've tried but could not find the DisableOptimizations attribute. Where > did you see it? > > Cheers, > Dominik > > On 2016-03-03 16:06, Pallier, Manuel / BEKO Graz wrote: > > Hi, > > > > I just noticed the following attribute in the log4net 1.2.15 release build: > > [assembly: > Debuggable(DebuggableAttribute.DebuggingModes.DisableOptimizations | > DebuggableAttribute.DebuggingModes.IgnoreSymbolStoreSequencePoints)] > > > > Usually a .NET assembly build with optimizations for release has only one > flag in this attribute: > > [assembly: > Debuggable(DebuggableAttribute.DebuggingModes.IgnoreSymbolStoreSequencePoints)] > > > > The flag „DisableOptimizations“ seems to indicate that the assembly was > build without compiler optimizations. Is this by design? > > Version 1.2.13 didn’t have a Debuggable attribute at all. It seems like > 1.2.14 introduced it. From a quick look over the issues resolved in 1.2.14 > it might be related to https://issues.apache.org/jira/browse/LOG4NET-456 > > > > > > > -- Dominik Psenner
