[ 
https://issues.apache.org/jira/browse/LOG4NET-518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15342201#comment-15342201
 ] 

Dominik Psenner commented on LOG4NET-518:
-----------------------------------------

I just reviewed your patch and from what i have understood it makes filters 
more restrictive than they have been until now. Until your patch, a filter 
would filter log events if all requirements are met, now events are filtered if 
some requirements are met. Given that it breaks current functionality, your 
patch wont make it into trunk. Please feed back if my review was wrong.

> Filters don't work when use multiple.
> -------------------------------------
>
>                 Key: LOG4NET-518
>                 URL: https://issues.apache.org/jira/browse/LOG4NET-518
>             Project: Log4net
>          Issue Type: Bug
>          Components: Other
>    Affects Versions: 1.2.15
>            Reporter: huiqiang yan
>
> I have an application managed multiple AppDomains, and my master application 
> can get messages from all appDomain, then log them separately.
> I create appenders from each appDomains and use the 'domain name’ and 'log 
> level' to discriminate。
> RollingFileAppender appender = new RollingFileAppender();
> appender.AddFilter(new LevelRangeFilter
> {
>     LevelMin = Level.Info,
>     LevelMax = Level.Info,
>     AcceptOnMatch = false,
>     Next = new LoggerMatchFilter
>     {
>         LoggerToMatch = name,
>         AcceptOnMatch = true                    
>     }
> });
> when name doesn't match, the If statement in filter LoggerMatchFilter file at 
> line 140 ,I think it means match or doesn't match, it should be deny in else 
> statement.
> AcceptOnMatch only use when the match is passed ,it means if should return 
> Accept when matched,and when it is false then return Neutral.
> Not only LoggerMatchFilter has this problem, others too. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to