[
https://issues.apache.org/jira/browse/LOG4NET-526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15609324#comment-15609324
]
ASF GitHub Bot commented on LOG4NET-526:
----------------------------------------
Github user JJoe2 commented on the issue:
https://github.com/apache/log4net/pull/35
I’ll be happy to do the unit tests and possibly the doc. Are suitable XML
comments enough?
Now this is added, I’ll also be thinking about the next step, which is to
allow the PatternString converter to be used in the XML configuration file for
properties of types other than strings.
So that I can do something like:
<root>
<level type=”log4net.Util.PatternString” value="%appsetting{Logging.
Level}" />
</root>
Should be possible: basically be applying the PatternString conversion
before converting to the target type of the property.
From: Stefan Bodewig [mailto:notificati...@github.com]
Sent: 26 October 2016 20:43
To: apache/log4net
Cc: JJoe2; Author
Subject: Re: [apache/log4net] Wip/app settings (#35)
I've added your converter, many thanks.
Tests would be good and we need documentation before we can close
LOG4NET-526.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on
GitHub<https://github.com/apache/log4net/pull/35#issuecomment-256440366>, or
mute the
thread<https://github.com/notifications/unsubscribe-auth/AFY0uybBZ6IZdXI75BhcToQlNLFlHQY3ks5q359EgaJpZM4KMD7s>.
> Add appSetting conversion pattern to PatternString
> --------------------------------------------------
>
> Key: LOG4NET-526
> URL: https://issues.apache.org/jira/browse/LOG4NET-526
> Project: Log4net
> Issue Type: New Feature
> Components: Core
> Affects Versions: 1.2.15
> Reporter: Joe
> Priority: Minor
>
> A common requirement is to be able to define a base directory for log files
> that can be used by multiple FileAppenders. In this way, the directory only
> needs to be changed in one place.
> Today the typical solution is to use a PatternString with a property that is
> set in code before log4net is configured, e.g.
> <file type="log4net.Util.PatternString"
> value="%property{LogDIr}MyFile.log"/>
> Suggested feature is to allow a conversion pattern that reads the base
> directory name from an appSetting, e.g.:
> <file type="log4net.Util.PatternString"
> value="%appSetting{LogDIr}MyFile.log"/>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
