Knut Urdalen wrote:
Christian Hammers wrote:
...
Hi,
I think it's safe to add the $_SERVER variable here, and check it
before $_ENV. But still keep $_ENV like this:
if (defined($key)) {
return (string)constant($key);
+ } elseif (isset($_SERVER[$key])) {
+ return (string)$_SERVER[$key];
} elseif (isset($_ENV[$key])) {
return (string)$_ENV[$key];
} else {
return $def;
}
Do you agree?
Regards,
Knut Urdalen
That looks good too me.
Do we create a jira issue for something like this? so, for anything that
would require a commit?
Should every commit require an issue id? (that would be my assumption)
Alvaro
