On Mar 5, 2008, at 1:07 AM, Hiroaki Kawai wrote:
Hi,
While I was looking around the files, I found that the files
contains unwanted trailing "\n".
The files should end with "?>" and not "?>\n".
If we have a trailing \n, php will send a "\n" as a
content, and this cause some functions such as header(),
won't work properly.
Another style may be a Zend Framework style that
doesn't have ending "?>".
http://framework.zend.com/manual/en/coding-standard.php-file-formatting.html#coding-standard.php-file-formatting.general
Can I ask someone to rewrite for this work? or, I'd like to
do the work directly if I could have a permission to access
to the repository.
I'm not that knowledgeable on PHP, I primarily maintain log4j and
log4cxx, but the Zend Framework style would seem preferable. Many
other tools (C compilers, etc) will warn when a file does not end with
a line feed and reformatting tools will often add the "missing"
linefeed if the file ends with a different character.
Commit rights to the Apache repository requires a vote of the Logging
Services PMC and is generally granted only after a substantial period
of participation in the the community, a history of useful patches and
a signed Contributor License Agreement.
If you'd like to help, check out a copy of the SVN, fix up your copy,
then do
svn diff > lineend.patch
and then attach the patch file to a JIRA issue (http://issues.apache.org/jira
) which will allow one of the committers to review and apply the patch.
