[
https://issues.apache.org/jira/browse/LOG4PHP-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740408#action_12740408
]
Christian Grobmeier commented on LOG4PHP-56:
--------------------------------------------
The corresponding fields in Log4J from:
LOG4PHP_DEFAULT_INIT_OVERRIDE
LOG4PHP_CONFIGURATION
LOG4PHP_CONFIGURATOR_CLASS
are marked deprecated and for internal use only in Log4j 1.2.
I think removing the properties and having:
Logger::setConfigurationClass(Configurator $class)
Logger::setConfiguration($pathToConfiguration)
A initializer could be put too, but I think this feature isn't really worth
having it: one can override the class, if he wants too.
> Replace define('LOG4PHP_CONFIGURATION' by static variable
> ---------------------------------------------------------
>
> Key: LOG4PHP-56
> URL: https://issues.apache.org/jira/browse/LOG4PHP-56
> Project: Log4php
> Issue Type: Improvement
> Components: Code
> Affects Versions: 2.2
> Reporter: Christian Hammers
> Priority: Minor
> Fix For: 2.0
>
>
> As you're currently switching to PHP5 OOP code, I would suggest to replace
> this ugly global constant by a static attribute of the LogManager class i.e.
> LogManager::$configFile = ... Or maybe even a constructor/factory argument
> This would have the additional benefit that it could be set by some kind of
> Dependency Injection framework like Spring for Java, although I don't know of
> such is even existing for PHP :) But it might come in the future.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
