Author: grobmeier
Date: Fri Aug  7 20:31:25 2009
New Revision: 802170

URL: http://svn.apache.org/viewvc?rev=802170&view=rev
Log:
LOG4PHP-65: Removed shadowing members from LoggerRoot and used Loggers members 
were appropriate

Modified:
    incubator/log4php/trunk/src/changes/changes.xml
    incubator/log4php/trunk/src/main/php/LoggerRoot.php

Modified: incubator/log4php/trunk/src/changes/changes.xml
URL: 
http://svn.apache.org/viewvc/incubator/log4php/trunk/src/changes/changes.xml?rev=802170&r1=802169&r2=802170&view=diff
==============================================================================
--- incubator/log4php/trunk/src/changes/changes.xml (original)
+++ incubator/log4php/trunk/src/changes/changes.xml Fri Aug  7 20:31:25 2009
@@ -65,6 +65,7 @@
                <action type="update" issue="LOG4PHP-62">Does not print warning 
if ini file is corrupt (Christian Hammers)</action>
                <action type="update" issue="LOG4PHP-63">PDOAppender should 
throw LoggerException on database problems (Christian Hammers)</action>
                <action type="fix" issue="LOG4PHP-64">Remove deprecated 
call-by-reference in LoggerLayoutPattern (Christian Hammers)</action>
+               <action type="fix" issue="LOG4PHP-65">Mixing protected and 
private in Logger and the inheriting LoggerRoot (Christian Grobmeier)</action>
                <action type="fix" 
issue="LOG4PHP-66">LoggerConfiguratorBasicTest fails in "mvn test" but not in 
phpunit (Christian Hammers)</action>
                <action type="fix" issue="LOG4PHP-67">Refactoring: Use Logger 
instead of LoggerManager (Christian Hammers)</action>
                <action type="update">Initial port to PHP 5 (Knut 
Urdalen)</action>

Modified: incubator/log4php/trunk/src/main/php/LoggerRoot.php
URL: 
http://svn.apache.org/viewvc/incubator/log4php/trunk/src/main/php/LoggerRoot.php?rev=802170&r1=802169&r2=802170&view=diff
==============================================================================
--- incubator/log4php/trunk/src/main/php/LoggerRoot.php (original)
+++ incubator/log4php/trunk/src/main/php/LoggerRoot.php Fri Aug  7 20:31:25 2009
@@ -25,24 +25,14 @@
  * @see Logger
  */
 class LoggerRoot extends Logger {
-
-       /**
-        * @var string name of logger 
-        */
-       protected $name = 'root';
-
-       /**
-        * @var object must be null for LoggerRoot
-        */
-       protected $parent = null;
-       
        /**
         * Constructor
         *
         * @param integer $level initial log level
         */
        public function __construct($level = null) {
-               parent::__construct($this->name);
+               parent::__construct('root');
+
                if($level == null) {
                        $level = LoggerLevel::getLevelAll();
                }


Reply via email to