svn commit: r809471 - in /incubator/log4php/trunk/src: main/php/renderers/ test/php/configurators/ test/php/renderers/

[grobmeier]

Author: grobmeier
Date: Mon Aug 31 06:43:07 2009
New Revision: 809471

URL: http://svn.apache.org/viewvc?rev=809471&view=rev
Log:
made LoggerRendererObject a interface instead of an abstract class

Modified:
    incubator/log4php/trunk/src/main/php/renderers/LoggerRendererDefault.php
    incubator/log4php/trunk/src/main/php/renderers/LoggerRendererObject.php
    
incubator/log4php/trunk/src/test/php/configurators/LoggerConfiguratorIniTest.php
    
incubator/log4php/trunk/src/test/php/configurators/LoggerConfiguratorXmlTest.php
    incubator/log4php/trunk/src/test/php/renderers/LoggerRendererDefaultTest.php

Modified: 
incubator/log4php/trunk/src/main/php/renderers/LoggerRendererDefault.php
URL: 
http://svn.apache.org/viewvc/incubator/log4php/trunk/src/main/php/renderers/LoggerRendererDefault.php?rev=809471&r1=809470&r2=809471&view=diff
==============================================================================
--- incubator/log4php/trunk/src/main/php/renderers/LoggerRendererDefault.php 
(original)
+++ incubator/log4php/trunk/src/main/php/renderers/LoggerRendererDefault.php 
Mon Aug 31 06:43:07 2009
@@ -24,7 +24,7 @@
  * @subpackage renderers
  * @since 0.3
  */
-class LoggerRendererDefault extends LoggerRendererObject {
+class LoggerRendererDefault implements LoggerRendererObject {
 
        /**
         * Render objects by type casting
@@ -32,7 +32,7 @@
         * @param mixed $o the object to render
         * @return string
         */
-       public function doRender($o) {
+       public function render($o) {
                return var_export($o, true);
        }
 }

Modified: 
incubator/log4php/trunk/src/main/php/renderers/LoggerRendererObject.php
URL: 
http://svn.apache.org/viewvc/incubator/log4php/trunk/src/main/php/renderers/LoggerRendererObject.php?rev=809471&r1=809470&r2=809471&view=diff
==============================================================================
--- incubator/log4php/trunk/src/main/php/renderers/LoggerRendererObject.php 
(original)
+++ incubator/log4php/trunk/src/main/php/renderers/LoggerRendererObject.php Mon 
Aug 31 06:43:07 2009
@@ -26,11 +26,11 @@
  * @abstract
  * @since 0.3
  */
-abstract class LoggerRendererObject {
+interface LoggerRendererObject {
        /**
         * Render the entity passed as parameter as a String.
         * @param mixed $o entity to render
         * @return string
         */
-       abstract public function doRender($o);
+       public function render($o);
 }

Modified: 
incubator/log4php/trunk/src/test/php/configurators/LoggerConfiguratorIniTest.php
URL: 
http://svn.apache.org/viewvc/incubator/log4php/trunk/src/test/php/configurators/LoggerConfiguratorIniTest.php?rev=809471&r1=809470&r2=809471&view=diff
==============================================================================
--- 
incubator/log4php/trunk/src/test/php/configurators/LoggerConfiguratorIniTest.php
 (original)
+++ 
incubator/log4php/trunk/src/test/php/configurators/LoggerConfiguratorIniTest.php
 Mon Aug 31 06:43:07 2009
@@ -29,8 +29,8 @@
     public $test3 = 'test3';
 }
 
-class FruitRenderer extends LoggerRendererObject {
-    public function doRender($o) {
+class FruitRenderer implements LoggerRendererObject {
+    public function render($o) {
                return $o->test1.','.$o->test2.','.$o->test3;
        }
 }

Modified: 
incubator/log4php/trunk/src/test/php/configurators/LoggerConfiguratorXmlTest.php
URL: 
http://svn.apache.org/viewvc/incubator/log4php/trunk/src/test/php/configurators/LoggerConfiguratorXmlTest.php?rev=809471&r1=809470&r2=809471&view=diff
==============================================================================
--- 
incubator/log4php/trunk/src/test/php/configurators/LoggerConfiguratorXmlTest.php
 (original)
+++ 
incubator/log4php/trunk/src/test/php/configurators/LoggerConfiguratorXmlTest.php
 Mon Aug 31 06:43:07 2009
@@ -28,8 +28,8 @@
     public $test3 = 'test3';
 }
 
-class FruitRenderer2 extends LoggerRendererObject {
-    public function doRender($o) {
+class FruitRenderer2 implements LoggerRendererObject {
+    public function render($o) {
                return $o->test1.','.$o->test2.','.$o->test3;
        }
 }

Modified: 
incubator/log4php/trunk/src/test/php/renderers/LoggerRendererDefaultTest.php
URL: 
http://svn.apache.org/viewvc/incubator/log4php/trunk/src/test/php/renderers/LoggerRendererDefaultTest.php?rev=809471&r1=809470&r2=809471&view=diff
==============================================================================
--- 
incubator/log4php/trunk/src/test/php/renderers/LoggerRendererDefaultTest.php 
(original)
+++ 
incubator/log4php/trunk/src/test/php/renderers/LoggerRendererDefaultTest.php 
Mon Aug 31 06:43:07 2009
@@ -34,7 +34,7 @@
        public function testDoRender() {
                $class = new DefaultRendererMockObject();
                $renderer = new LoggerRendererDefault();
-               self::assertEquals(var_export($class, true), 
$renderer->doRender($class));
+               self::assertEquals(var_export($class, true), 
$renderer->render($class));
        }
 
 }