Author: chammers
Date: Tue Oct 6 18:12:50 2009
New Revision: 822392
URL: http://svn.apache.org/viewvc?rev=822392&view=rev
Log:
* type-safety doesn't hurt
* Added @package for phpdoc
Modified:
incubator/log4php/trunk/src/main/php/LoggerAppender.php
incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderAdodb.php
incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderConsole.php
incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderEcho.php
incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderFile.php
incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderMail.php
incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderMailEvent.php
incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderNull.php
incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderPDO.php
incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderPhp.php
incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderRollingFile.php
incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderSocket.php
incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderSyslog.php
Modified: incubator/log4php/trunk/src/main/php/LoggerAppender.php
URL:
http://svn.apache.org/viewvc/incubator/log4php/trunk/src/main/php/LoggerAppender.php?rev=822392&r1=822391&r2=822392&view=diff
==============================================================================
--- incubator/log4php/trunk/src/main/php/LoggerAppender.php (original)
+++ incubator/log4php/trunk/src/main/php/LoggerAppender.php Tue Oct 6 18:12:50
2009
@@ -15,6 +15,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*
+ * @package log4php
*/
/**
@@ -113,7 +114,7 @@
* @see LoggerAppender::doAppend()
* @param LoggerLoggingEvent $event
*/
- public function doAppend($event) {
+ public function doAppend(LoggerLoggingEvent $event) {
if($this->closed) {
return;
}
@@ -248,7 +249,7 @@
* @see doAppend()
* @abstract
*/
- abstract protected function append($event);
+ abstract protected function append(LoggerLoggingEvent $event);
/**
* Release any resources allocated.
Modified: incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderAdodb.php
URL:
http://svn.apache.org/viewvc/incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderAdodb.php?rev=822392&r1=822391&r2=822392&view=diff
==============================================================================
--- incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderAdodb.php
(original)
+++ incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderAdodb.php Tue
Oct 6 18:12:50 2009
@@ -147,7 +147,7 @@
$this->canAppend = true;
}
- function append($event) {
+ function append(LoggerLoggingEvent $event) {
if ($this->canAppend) {
$query = $this->layout->format($event);
$this->db->Execute($query);
Modified:
incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderConsole.php
URL:
http://svn.apache.org/viewvc/incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderConsole.php?rev=822392&r1=822391&r2=822392&view=diff
==============================================================================
--- incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderConsole.php
(original)
+++ incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderConsole.php
Tue Oct 6 18:12:50 2009
@@ -91,7 +91,7 @@
}
}
- public function append($event) {
+ public function append(LoggerLoggingEvent $event) {
if (is_resource($this->fp) && $this->layout !== null) {
fwrite($this->fp, $this->layout->format($event));
}
Modified: incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderEcho.php
URL:
http://svn.apache.org/viewvc/incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderEcho.php?rev=822392&r1=822391&r2=822392&view=diff
==============================================================================
--- incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderEcho.php
(original)
+++ incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderEcho.php Tue
Oct 6 18:12:50 2009
@@ -56,7 +56,7 @@
$this->closed = true;
}
- public function append($event) {
+ public function append(LoggerLoggingEvent $event) {
if($this->layout !== null) {
if($this->firstAppend) {
echo $this->layout->getHeader();
Modified: incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderFile.php
URL:
http://svn.apache.org/viewvc/incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderFile.php?rev=822392&r1=822391&r2=822392&view=diff
==============================================================================
--- incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderFile.php
(original)
+++ incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderFile.php Tue
Oct 6 18:12:50 2009
@@ -95,7 +95,7 @@
}
}
- public function append($event) {
+ public function append(LoggerLoggingEvent $event) {
if($this->fp and $this->layout !== null) {
if(flock($this->fp, LOCK_EX)) {
fwrite($this->fp,
$this->layout->format($event));
Modified: incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderMail.php
URL:
http://svn.apache.org/viewvc/incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderMail.php?rev=822392&r1=822391&r2=822392&view=diff
==============================================================================
--- incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderMail.php
(original)
+++ incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderMail.php Tue
Oct 6 18:12:50 2009
@@ -101,7 +101,7 @@
$this->dry = $dry;
}
- public function append($event) {
+ public function append(LoggerLoggingEvent $event) {
if($this->layout !== null) {
$this->body .= $this->layout->format($event);
}
Modified:
incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderMailEvent.php
URL:
http://svn.apache.org/viewvc/incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderMailEvent.php?rev=822392&r1=822391&r2=822392&view=diff
==============================================================================
--- incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderMailEvent.php
(original)
+++ incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderMailEvent.php
Tue Oct 6 18:12:50 2009
@@ -115,7 +115,7 @@
$this->dry = $dry;
}
- public function append($event) {
+ public function append(LoggerLoggingEvent $event) {
$from = $this->from;
$to = $this->to;
if(empty($from) or empty($to)) {
Modified: incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderNull.php
URL:
http://svn.apache.org/viewvc/incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderNull.php?rev=822392&r1=822391&r2=822392&view=diff
==============================================================================
--- incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderNull.php
(original)
+++ incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderNull.php Tue
Oct 6 18:12:50 2009
@@ -48,7 +48,7 @@
*
* @param LoggerLoggingEvent $event
*/
- public function append($event) {
+ public function append(LoggerLoggingEvent $event) {
}
}
Modified: incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderPDO.php
URL:
http://svn.apache.org/viewvc/incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderPDO.php?rev=822392&r1=822391&r2=822392&view=diff
==============================================================================
--- incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderPDO.php
(original)
+++ incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderPDO.php Tue
Oct 6 18:12:50 2009
@@ -130,7 +130,7 @@
* Appends a new event to the database using the sql format.
*/
// TODO:should work with prepared statement
- public function append($event) {
+ public function append(LoggerLoggingEvent $event) {
if ($this->canAppend) {
$query = $this->layout->format($event);
try {
Modified: incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderPhp.php
URL:
http://svn.apache.org/viewvc/incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderPhp.php?rev=822392&r1=822391&r2=822392&view=diff
==============================================================================
--- incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderPhp.php
(original)
+++ incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderPhp.php Tue
Oct 6 18:12:50 2009
@@ -48,7 +48,7 @@
$this->closed = true;
}
- public function append($event) {
+ public function append(LoggerLoggingEvent $event) {
if($this->layout !== null) {
$level = $event->getLevel();
if($level->isGreaterOrEqual(LoggerLevel::getLevelError())) {
Modified:
incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderRollingFile.php
URL:
http://svn.apache.org/viewvc/incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderRollingFile.php?rev=822392&r1=822391&r2=822392&view=diff
==============================================================================
---
incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderRollingFile.php
(original)
+++
incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderRollingFile.php
Tue Oct 6 18:12:50 2009
@@ -200,7 +200,7 @@
/**
* @param LoggerLoggingEvent $event
*/
- public function append($event) {
+ public function append(LoggerLoggingEvent $event) {
parent::append($event);
if(ftell($this->fp) > $this->getMaximumFileSize()) {
$this->rollOver();
Modified:
incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderSocket.php
URL:
http://svn.apache.org/viewvc/incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderSocket.php?rev=822392&r1=822391&r2=822392&view=diff
==============================================================================
--- incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderSocket.php
(original)
+++ incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderSocket.php Tue
Oct 6 18:12:50 2009
@@ -219,7 +219,7 @@
/**
* @param LoggerLoggingEvent
*/
- public function append($event) {
+ public function append(LoggerLoggingEvent $event) {
if($this->sp || $this->dry) {
if($this->getLocationInfo()) {
$event->getLocationInformation();
Modified:
incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderSyslog.php
URL:
http://svn.apache.org/viewvc/incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderSyslog.php?rev=822392&r1=822391&r2=822392&view=diff
==============================================================================
--- incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderSyslog.php
(original)
+++ incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderSyslog.php Tue
Oct 6 18:12:50 2009
@@ -153,7 +153,7 @@
}
}
- public function append($event) {
+ public function append(LoggerLoggingEvent $event) {
if($this->_option == NULL){
$this->_option = LOG_PID | LOG_CONS;
}
