Hi Christian. > -----Original Message----- > From: Christian Hammers [mailto:[email protected]] > Sent: Sunday, 11 October 2009 9:59 AM > To: Log4PHP Dev > Subject: Re: [jira] Updated: (LOG4PHP-85) Unittest fail due to changed > default of xmlLayout->setLocationInfo > > Hi > > Thanks! > > BTW, What's the difference between "Close Issue" and "Resolve Issue"?
Not too much difference as far as we are concerned I don't think. Either will do, though I'd prefer 'Closed' as it sounds more like 'definitely finished', whereas 'Resolved' means yes the issue has been resolved, not so final. I guess the original thinking was that some issues could be closed as 'wont fix' or 'invalid' is which case technically speaking they weren't really resolved, but closed. If you want to 'resolved' first any issues actually worked on and then finally 'Close' them off that would seem a good workflow. But each project does things their own way; so just pick what seems sensible for you. Gav... > > bye, > > -christian- > > Am Sun, 11 Oct 2009 09:43:16 +1000 > schrieb "Gavin" <[email protected]>: > > > Hi Christian, > > > > I have added you to the relevant permissions on jira so you should be > > able to assign log4php issues to yourself now and also close them > > when complete. > > > > HTH > > > > Gav... > > > > > > > -----Original Message----- > > > From: Christian Hammers (JIRA) [mailto:[email protected]] > > > Sent: Sunday, 11 October 2009 9:37 AM > > > To: [email protected] > > > Subject: [jira] Updated: (LOG4PHP-85) Unittest fail due to changed > > > default of xmlLayout->setLocationInfo > > > > > > > > > [ https://issues.apache.org/jira/browse/LOG4PHP- > > > 85?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] > > > > > > Christian Hammers updated LOG4PHP-85: > > > ------------------------------------- > > > > > > Fix Version/s: 2.0 > > > Affects Version/s: 2.0 > > > > > > fixed in svn > > > > > > > Unittest fail due to changed default of xmlLayout->setLocationInfo > > > > ------------------------------------------------------------------ > > > > > > > > Key: LOG4PHP-85 > > > > URL: > > > > https://issues.apache.org/jira/browse/LOG4PHP-85 Project: Log4php > > > > Issue Type: Bug > > > > Components: Tests > > > > Affects Versions: 2.0 > > > > Reporter: Christian Hammers > > > > Fix For: 2.0 > > > > > > > > > > > > Currently the unit tests on my working copy fail with: > > > > 1) testSocketXml(LoggerAppenderSocketTest) > > > > Failed asserting that two strings are equal. > > > > --- Expected > > > > +++ Actual > > > > @@ -1,5 +1,4 @@ > > > > DRY MODE OF SOCKET APPENDER: <log4php:event logger="TEST" > > > > level="ERROR" > > > thread="11857" timestamp="1252964319758"> > > > > <log4php:message><![CDATA[testmessage]]></log4php:message> > > > > -<log4php:locationInfo class="LoggerLoggingEvent" file="NA" > > > > line="NA" > > > method="getLocationInformation" /> > > > > </log4php:event> > > > > They do not on the current trunk at r814880. On further > > > > investigation I > > > found that the output of a LoggerAppenderSocket, which internally > > > uses an LoggerLayoutXML is compared to a pure LoggerLayoutXML. > > > > The first LoggerAppenderSocket though has locationInfo=false as > > > > default > > > and passes this on to the layout. The newly created layout still > > > has this value on true. > > > > So in fact the test should have failed all the time and does now > > > > as I > > > already have the new toBoolean method (see bug 81). A patch would > > > be: > > > > --- src/test/php/appenders/LoggerAppenderSocketTest.php (Revision > > > 814880) > > > > +++ src/test/php/appenders/LoggerAppenderSocketTest.php > > > > (Arbeitskopie) @@ -50,6 +50,7 @@ > > > > $appender->setDry(true); > > > > $appender->setUseXml(true); > > > > + $appender->setLocationInfo(true); > > > > $appender->activateOptions(); > > > > $event = new > > > LoggerLoggingEvent("LoggerAppenderSocketTest", new Logger("TEST"), > > > LoggerLevel::getLevelError(), "testmessage"); > > > > > > -- > > > This message is automatically generated by JIRA. > > > - > > > You can reply to this email to add a comment to the issue online. > > > > > > No virus found in this incoming message. > > > Checked by AVG - www.avg.com > > > Version: 8.5.421 / Virus Database: 270.14.8/2423 - Release Date: > > > 10/10/09 06:39:00 > > > No virus found in this incoming message. > Checked by AVG - www.avg.com > Version: 8.5.421 / Virus Database: 270.14.8/2423 - Release Date: 10/10/09 > 06:39:00
