Got a couple of issues with the docs, in order of significance:
1. No "Apache", version number or incubating disclaimer on generated docs. The generated docs have a generic title "Generated Documentation" and log4php stands by itself, really should be "Apache log4php 2.0.0 (incubating)" or something like that. 2. No ASF header in generated docs From http://www.apache.org/legal/src-headers.html > What if my project includes its web site within a product distribution? > > With few exceptions, all human-readable Apache-developed files that are > included within a distribution must include the header text. Documentation, > including web site documentation distributed with the release, may include > the header text within some form of metadata (such as HTML comments) or as a > header or footer appearing in the visible documentation. Also http://incubator.apache.org/guides/releasemanagement.html#notes-license-headers > > The issue of licenses on generated documentation is a little controversial. > Copyright may not subsist in a document which is generated by an > transformation from an original. In which case, the license header may be > unnecessary. License headers should always be present in the original. Where > it is reasonable to do so, the templates should also add the license header > to the generated documents. > If the license header could be templated in as an HTML comment, it would eliminate this as a point of contention. 3. Generated docs placed in target/site directory. target is the default build directory for maven. Typically, the site built with the release is placed in doc, leaving the target directory available for end-user builds. Otherwise, it is easy for a Java developer to inadvertently write over the released documentation. The "includeSiteDirectory" descriptor in Maven's assembly plugin isn't adequately described, but I'm guessing it works with the javadoc plugin and does that relocation automatically, but it doesn't do the same for phpdoc. 4. PEAR doesn't include log4php.dtd 5. src/assembly/bin.xml has an obsolete name, src.xml would likely be better. Don't know if it would be an issue, but it is included in src/main/php/xml in the source releases and not in the PEAR release. I'm thinking the cumulative is a -1 for me. Sorry I wasn't able to pick this up sooner. Maven's RAT didn't pick up on the license header since it doesn't check the target directory, it does if you move target/site to doc. I don't know if standalone RAT would have flagged it. I'm going to have some free time on Monday and Tuesday night, but am likely out of touch till then.
