[
https://issues.apache.org/jira/browse/LOG4PHP-102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christian Grobmeier resolved LOG4PHP-102.
-----------------------------------------
Resolution: Fixed
Fix Version/s: 2.1
Thanks much!
I haven chosen the second option because of the performance issues you
mentioned. I didn't test it yet and we should check this, but in the first step
lets stay on the safe side.
The test cases are great too! Its always good to have it.
> LoggerLayoutPattern fails tests
> -------------------------------
>
> Key: LOG4PHP-102
> URL: https://issues.apache.org/jira/browse/LOG4PHP-102
> Project: Log4php
> Issue Type: Bug
> Components: Code
> Affects Versions: 2.0
> Reporter: Ivan Habunek
> Priority: Minor
> Fix For: 2.1
>
> Attachments: LoggerLayoutPatternTest.patch.txt,
> LoggerPatternConverter.patch.quickfix.txt,
> LoggerPatternConverter.patch.rewrite.txt
>
>
> In LoggerLayoutPatternTest class, the testWarnLayout() method is commented
> out because it fails with the following message:
> 1) testWarnLayout(LoggerLayoutPatternTest)
> Undefined index: log4php.LoggerPatternConverter.spaces
> /Users/cgrobmeier/Documents/Development/workspace/log4php-trunk/src/main/php/helpers/LoggerPatternConverter.php:131
> /Users/cgrobmeier/Documents/Development/workspace/log4php-trunk/src/main/php/helpers/LoggerPatternConverter.php:104
> /Users/cgrobmeier/Documents/Development/workspace/log4php-trunk/src/main/php/layouts/LoggerPatternLayout.php:216
> /Users/cgrobmeier/Documents/Development/workspace/log4php-trunk/src/test/php/layouts/LoggerLayoutPatternTest.php:45
> This seems to be related to using a global variable
> $GLOBALS['log4php.LoggerPatternConverter.spaces'] in
> LoggerPatternConverter::spacePad(). I am unsure why the global variable is
> not accessible in this test, but using a global variable seems the wrong
> approach here anyway.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
