[ 
https://issues.apache.org/jira/browse/LOG4PHP-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860128#action_12860128
 ] 

Christian Grobmeier commented on LOG4PHP-109:
---------------------------------------------

Hi,

i was reviewing it. It works with testcases, but I have a question.

do we really need a refernence to the Logger object in 
LoggerThrowableInformation? I think not and would like to delete it out, if you 
have no objections on that

I will commit it without the reference and slightly modified, but maybe you 
could review my changes and discuss further

Cheers
Christian

> patch for Throwable information associated with logging event
> -------------------------------------------------------------
>
>                 Key: LOG4PHP-109
>                 URL: https://issues.apache.org/jira/browse/LOG4PHP-109
>             Project: Log4php
>          Issue Type: New Feature
>          Components: Code, Documentation, Tests
>    Affects Versions: 2.0
>         Environment: PHP
>            Reporter: Vladimir Gorej
>             Fix For: 2.1
>
>         Attachments: throwableinfo.patch, throwableInfo.patch
>
>
> I have created patch for throwable information associated with logging event. 
> With this patch applied it will be possible to log exceptions and nested 
> exceptions with their full stack traces

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to