[
https://issues.apache.org/jira/browse/LOG4PHP-147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094389#comment-13094389
]
Ivan Habunek commented on LOG4PHP-147:
--------------------------------------
Hi,
Since there's a lot of code here, I will mark my answers with a asterisk (*)
and they will be below the line I'm commenting on.
"UnknownClass":
["log4php/appenders/LoggerAppenderMongoDB.php",119,23,119,76] ,"d":"new
Mongo(sprintf('%s:%d', $this->host, $this->port))"
["log4php/appenders/LoggerAppenderMongoDB.php",160,19,160,63] ,"d":"new
MongoDate($timestampSec, $timestampUsec)"
* For Mongo and MongoDate, you need to have the MongoDB extnesion loaded. It
can be found here: http://www.mongodb.org/display/DOCS/PHP+Language+Center
["log4php/helpers/LoggerPatternParser.php",309,12,309,104] ,"d":"new
LoggerUserFieldPatternConverter($this->formattingInfo, (string)ord($cNext) -
48)"
* The issue with LoggerUserFieldPatternConverter was resolved in LOG4PHP-148.
"UnknownObjectMethod":
["log4php/appenders/LoggerAppenderMongoDB.php",120,26,120,57]
,"d":"$this->connection->selectDB($this->databaseName)"
["log4php/appenders/LoggerAppenderMongoDB.php",122,69,122,69]
,"d":"$db->authenticate($this->userName, $this->password)"
["log4php/appenders/LoggerAppenderMongoDB.php",128,67,128,67]
,"d":"$db->selectCollection($this->collectionName)"
["log4php/appenders/LoggerAppenderMongoDB.php",145,20,145,39]
,"d":"$this->collection->insert($document)"
* You need the MongoDB extension
["log4php/appenders/LoggerAppenderMongoDB.php",198,61,198,61]
,"d":"$ex->getPrevious()"
["log4php/appenders/LoggerAppenderMongoDB.php",199,71,199,71]
,"d":"$ex->getPrevious()"
["log4php/renderers/LoggerRendererException.php",34,59,34,59]
,"d":"$o->getPrevious()"
["log4php/renderers/LoggerRendererException.php",35,67,35,67]
,"d":"$o->getPrevious()"
* The Exception::getPrevious() method was added in PHP 5.3, you are presumably
using 5.2.
"UnknownFunction":
["log4php/Logger.php",25,0,25,50] ,"d":"spl_autoload_register(array('Logger',
'autoload'))"
* The method Logger::autoload() exists, I don't know why it raises an error.
["log4php/appenders/LoggerAppenderAdodb.php",122,15,122,44]
,"d":"adonewconnection($this->type)"
* This requires the ADODB extension. It can be found here:
http://adodb.sourceforge.net/
["log4php/appenders/LoggerAppenderSocket.php",188,2,188,17]
,"d":"parent::reset()"
* This is an error. The parent class has no reset method. I will remove this
method call.
"RequiredAfterOptionalParam":
["log4php/configurators/LoggerConfiguratorXml.php",138,30,138,68]
,"d":"LoggerHierarchy $repository"
* This is an error, the optional parameter should never come before the
required ones. It will be fixed.
"UseVoidReturn":
["log4php/LoggerReflectionUtils.php",52,54,52,54]
,"d":"$pSetter->setProperties($properties, $prefix)"
* I suppose the problem is that setProperties returns null, and that null is
used (returned). Can you try to remove the return keyword from line 52, and see
if this fixed the problem? Just do this:
- return $pSetter->setProperties($properties, $prefix);
+ $pSetter->setProperties($properties, $prefix);
"UseUndeclaredConstant":
["log4php/appenders/LoggerAppenderAdodb.php",22,13,22,22] ,"d":"ADODB_DIR"
* I will add a check to see if ADODB_DIR is defined before using it. This
should solve the issue.
Note that the LoggerAppenderAdodb class is deprecated. I will discuss removing
it from the code base, since it has been marked deprecated for a long while.
This will solve all adodb related issues.
Hope this helps.
Best regards,
Ivan
> Bugs during HipHop build
> ------------------------
>
> Key: LOG4PHP-147
> URL: https://issues.apache.org/jira/browse/LOG4PHP-147
> Project: Log4php
> Issue Type: Bug
> Environment: Linux
> Reporter: Hitesh Kumar
> Labels: build
>
> The following log4php errors show up during the HipHop build:
> "UnknownClass":[
> {"c1":
>
> ["\/var\/lib\/tomcat6\/webapps\/hudson\/jobs\/Rontgen\/workspace\/lib\/log4php\/appenders\/LoggerAppenderMongoDB.php",119,23,119,76]
> ,"d":"new Mongo(sprintf('%s:%d', $this->host, $this->port))"
> } ,
> {"c1":
>
> ["\/var\/lib\/tomcat6\/webapps\/hudson\/jobs\/Rontgen\/workspace\/lib\/log4php\/appenders\/LoggerAppenderMongoDB.php",160,19,160,63]
> ,"d":"new MongoDate($timestampSec, $timestampUsec)"
> } ,
> {"c1":
>
> ["\/var\/lib\/tomcat6\/webapps\/hudson\/jobs\/Rontgen\/workspace\/lib\/log4php\/helpers\/LoggerPatternParser.php",309,12,309,104]
> ,"d":"new LoggerUserFieldPatternConverter($this->formattingInfo,
> (string)ord($cNext) - 48)"
> }
> ]
> "UnknownObjectMethod":[
> {"c1":
>
> ["\/var\/lib\/tomcat6\/webapps\/hudson\/jobs\/Rontgen\/workspace\/lib\/log4php\/appenders\/LoggerAppenderMongoDB.php",120,26,120,57]
> ,"d":"$this->connection->selectDB($this->databaseName)"
> } ,
> {"c1":
>
> ["\/var\/lib\/tomcat6\/webapps\/hudson\/jobs\/Rontgen\/workspace\/lib\/log4php\/appenders\/LoggerAppenderMongoDB.php",122,69,122,69]
> ,"d":"$db->authenticate($this->userName, $this->password)"
> } ,
> {"c1":
>
> ["\/var\/lib\/tomcat6\/webapps\/hudson\/jobs\/Rontgen\/workspace\/lib\/log4php\/appenders\/LoggerAppenderMongoDB.php",128,67,128,67]
> ,"d":"$db->selectCollection($this->collectionName)"
> } ,
> {"c1":
>
> ["\/var\/lib\/tomcat6\/webapps\/hudson\/jobs\/Rontgen\/workspace\/lib\/log4php\/appenders\/LoggerAppenderMongoDB.php",145,20,145,39]
> ,"d":"$this->collection->insert($document)"
> } ,
> {"c1":
>
> ["\/var\/lib\/tomcat6\/webapps\/hudson\/jobs\/Rontgen\/workspace\/lib\/log4php\/appenders\/LoggerAppenderMongoDB.php",198,61,198,61]
> ,"d":"$ex->getPrevious()"
> } ,
> {"c1":
>
> ["\/var\/lib\/tomcat6\/webapps\/hudson\/jobs\/Rontgen\/workspace\/lib\/log4php\/appenders\/LoggerAppenderMongoDB.php",199,71,199,71]
> ,"d":"$ex->getPrevious()"
> } ,
> {"c1":
>
> ["\/var\/lib\/tomcat6\/webapps\/hudson\/jobs\/Rontgen\/workspace\/lib\/log4php\/renderers\/LoggerRendererException.php",34,59,34,59]
> ,"d":"$o->getPrevious()"
> } ,
> {"c1":
>
> ["\/var\/lib\/tomcat6\/webapps\/hudson\/jobs\/Rontgen\/workspace\/lib\/log4php\/renderers\/LoggerRendererException.php",35,67,35,67]
> ,"d":"$o->getPrevious()"
> }
> ]
> "UnknownFunction":[
> {"c1":
>
> ["\/var\/lib\/tomcat6\/webapps\/hudson\/jobs\/Rontgen\/workspace\/lib\/log4php\/Logger.php",25,0,25,50]
> ,"d":"spl_autoload_register(array('Logger', 'autoload'))"
> } ,
> {"c1":
>
> ["\/var\/lib\/tomcat6\/webapps\/hudson\/jobs\/Rontgen\/workspace\/lib\/log4php\/appenders\/LoggerAppenderAdodb.php",122,15,122,44]
> ,"d":"adonewconnection($this->type)"
> } ,
> {"c1":
>
> ["\/var\/lib\/tomcat6\/webapps\/hudson\/jobs\/Rontgen\/workspace\/lib\/log4php\/appenders\/LoggerAppenderSocket.php",188,2,188,17]
> ,"d":"parent::reset()"
> }
> ]
> "RequiredAfterOptionalParam":[
> {"c1":
>
> ["\/var\/lib\/tomcat6\/webapps\/hudson\/jobs\/Rontgen\/workspace\/lib\/log4php\/configurators\/LoggerConfiguratorXml.php",138,30,138,68]
> ,"d":"LoggerHierarchy $repository"
> }
> ]
> "UseVoidReturn":[
> {"c1":
>
> ["\/var\/lib\/tomcat6\/webapps\/hudson\/jobs\/Rontgen\/workspace\/lib\/log4php\/LoggerReflectionUtils.php",52,54,52,54]
> ,"d":"$pSetter->setProperties($properties, $prefix)"
> }
> ]
> "UseUndeclaredConstant":[
> {"c1":
>
> ["\/var\/lib\/tomcat6\/webapps\/hudson\/jobs\/Rontgen\/workspace\/lib\/log4php\/appenders\/LoggerAppenderAdodb.php",22,13,22,22]
> ,"d":"ADODB_DIR"
> }
> ]
> Please suggest a way to fix them, or if it's not fixable in the released
> version, please fix them in the to-be-released version.
> Thanks
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
