Hi! Good catch. Fixed it now. Have another look please.
Regards, Ivan On 22 December 2011 15:31, Christian Grobmeier <[email protected]> wrote: > Hi Ivan, > > I can see: DEFAULT_TIMEOUT_VALUE > but I cannot see how it is used - so far it looks to me always 0 is > used in case no timeout has been specified > > Cheers > > On Thu, Dec 22, 2011 at 2:30 PM, Ivan Habunek (Resolved) (JIRA) > <[email protected]> wrote: >> >> [ >> https://issues.apache.org/jira/browse/LOG4PHP-166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel >> ] >> >> Ivan Habunek resolved LOG4PHP-166. >> ---------------------------------- >> >> Resolution: Fixed >> Fix Version/s: 2.3 >> Assignee: Ivan Habunek >> >> Thanks for the contribution. I have added the docs & tests for the new >> parameter. The code is in trunk and will be released in 2.3. >> >>> LoggerAppenderMongoDB should supply a timeout value to the Mongo() >>> constructor when it connects for the first time. >>> ------------------------------------------------------------------------------------------------------------------- >>> >>> Key: LOG4PHP-166 >>> URL: https://issues.apache.org/jira/browse/LOG4PHP-166 >>> Project: Log4php >>> Issue Type: Improvement >>> Components: Code >>> Affects Versions: 2.1, 2.2 >>> Reporter: David Hilowitz >>> Assignee: Ivan Habunek >>> Priority: Minor >>> Fix For: 2.3 >>> >>> Attachments: patch_commit_59b06e94668f.patch >>> >>> Original Estimate: 2h >>> Remaining Estimate: 2h >>> >>> It would be great if LoggerAppenderMongoDB could supply a timeout value to >>> the Mongo() constructor when it connects for the first time. >>> Here's why: If something is wrong with the Mongo database server -- for >>> example, if the server is offline -- it often takes a really long time (10 >>> or more seconds) to fail and throw an exception. This is terrible in a >>> situation where we need a quick turnaround time and are using the logger to >>> collect diagnostic data. >>> Ideally, a timeout value could be specified in the log4php config XML file >>> along with the host, name, etc. >>> I already have a patch that fixes this issue. The main gist of it is this. >>> Change this: >>> $this->connection = new Mongo(sprintf('%s:%d', $this->host, $this->port)); >>> to this: >>> $this->connection = new Mongo(sprintf('%s:%d', $this->host, $this->port), >>> array("timeout" => $this->timeout)); >>> Useful Resources: >>> * PHP Docs that explain the Mongo() constructor timeout value: >>> http://php.net/manual/en/mongo.construct.php >> >> -- >> This message is automatically generated by JIRA. >> If you think it was sent incorrectly, please contact your JIRA >> administrators: >> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa >> For more information on JIRA, see: http://www.atlassian.com/software/jira >> >> > > > > -- > http://www.grobmeier.de > https://www.timeandbill.de
