On Fri, Feb 24, 2012 at 10:29 AM, Ivan Habunek <[email protected]> wrote: > Hi all, > > The current database appender has an option of creating a table if > none exists. I would prefer that it doesn't. There are two main > reasons: > 1. You cannot be sure that the CREATE TABLE statement will work on > every database. > 2. Since we don't know to which database we're connecting, it is > impossible to deduct which error the database reported (was it "table > not found" or "invalid password"). See current code, it's not nice. > > Instead, I would create a folder where CREATE TABLE statements will be > located for different databases. Similar to the way done on logback: > https://github.com/ceki/logback/tree/master/logback-classic/src/main/java/ch/qos/logback/classic/db/dialect
I am +1 on removing the sql from the appender. I am not sure about the "create table" statments. Do you mean they need to be executed by hand? Or is this some kind of automatic process? > Also in the works: > - retry on failed log (to solve LOG4PHP-134) aaaaah great! > - adaptations for the new pattern layout which pdo appender uses Also cool! Cheers > > Regards, > Ivan -- http://www.grobmeier.de https://www.timeandbill.de
