[ 
http://jira.qos.ch/browse/LBCLASSIC-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=10843#action_10843
 ] 

Joern Huxhorn commented on LBCLASSIC-72:
----------------------------------------

I'm absolutely fine with your change, thank you very much!

I personally tend to keep my datatypes mutable because there is no way to 
absolutely ensure that the data isn't changed anyway.
Instead, I make sure that "the correct thing" is happening when data is 
changed, i.e. I'd null steAsString in case of setSTE... but that is just a 
personal preference, I don't need the setter myself.

> Please implement a getter for StackTraceElementProxy.ste
> --------------------------------------------------------
>
>                 Key: LBCLASSIC-72
>                 URL: http://jira.qos.ch/browse/LBCLASSIC-72
>             Project: logback-classic
>          Issue Type: Improvement
>            Reporter: Joern Huxhorn
>            Assignee: Ceki Gulcu
>
> I just checked out your latest changes concerning package version information 
> because I have to implement it for Lilith when the next version of Logback is 
> released.
> At the moment StackTraceElementProxy does not have a getter for the contained 
> StackTraceElement. It would be really helpful for me if I could access it. 
> Otherwise I'd have to parse it from steAsString which I'd really like to 
> prevent.
> I'd suggest to implement both a getter and a setter for the StackTraceElement.
> steAsString would need to be set to null if the STE is changed.
> Additionally, I'd suggest to make steAsString transient since it can be 
> restored after deserialization.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.qos.ch/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        
_______________________________________________
logback-dev mailing list
[email protected]
http://qos.ch/mailman/listinfo/logback-dev

Reply via email to