[
http://jira.qos.ch/browse/LBCORE-34?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ceki Gulcu resolved LBCORE-34.
------------------------------
Fix Version/s: 0.9.12
Resolution: Fixed
fixed as suggested in revision 1914
> Improve WriterAppender
> ----------------------
>
> Key: LBCORE-34
> URL: http://jira.qos.ch/browse/LBCORE-34
> Project: logback-core
> Issue Type: Improvement
> Components: Appender
> Affects Versions: unspecified
> Environment: Operating System: All
> Platform: All
> Reporter: Anders Hammar
> Assignee: Logback dev list
> Priority: Minor
> Fix For: 0.9.12
>
>
> Reviewing the ch.qos.logback.core.WriterAppender class, I see that the
> attributes are 'protected' (not 'private'). However, there are set and get
> methods for most of them (but not all).
> I suggest making the attributes private and create setters and getters for
> all of them (there is no getWriter() for instance). This would prevent
> subclasses from incorrectly working directly against the attributes (for
> instance, not using the setWriter() would cause errors). If some 'public'
> getters are not desirable, at least 'protected' ones should be provided.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.qos.ch/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
_______________________________________________
logback-dev mailing list
[email protected]
http://qos.ch/mailman/listinfo/logback-dev
