[
http://jira.qos.ch/browse/LBCLASSIC-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=10910#action_10910
]
Ceki Gulcu commented on LBCLASSIC-46:
-------------------------------------
It should be quite easy to reconstruct the original STEs. Just search for the
first (or second) entry in the ThrowableDataPoint array which is a
rawString.Note that I am not closing this issue. This comment is just to let
you know that it can be easily done.
> ThrowableInformation should keep the Throwable cause hierarchy intact.
> ----------------------------------------------------------------------
>
> Key: LBCLASSIC-46
> URL: http://jira.qos.ch/browse/LBCLASSIC-46
> Project: logback-classic
> Issue Type: Improvement
> Components: Other
> Affects Versions: unspecified
> Environment: Operating System: All
> Platform: All
> Reporter: Joern Huxhorn
> Assignee: Ceki Gulcu
> Priority: Minor
>
> Instead of a String representation of the whole Throwable stack trace incl.
> cause ThrowableInformation should instead look like this:
> public class ThrowableInformation implements Serializable
> {
> String throwableClassName;
> String message;
> StackTraceElement[] stackTrace;
> ThrowableInformation cause;
> }
> I omitted get/set and private in this example.
> StackTraceElement is perfectly Serializable and did also receive a public
> c'tor in Java 5 so I guess that the current ThrowableInformation is more or
> less a relict of log4j which had to stay compatible with older Java versions.
> You could obviously keep the getThrowableStrRep() method for compatibility.
> This bug is somewhat related to LBCLASSIC-45 because I think that
> ThrowableInformation should also, as LoggingEvent, be just a dumb data
> container with no real logic.
> The logic to extract the relevant StackTraceElements should IMHO be moved
> either into Logger or into a static factory method of ThrowableInformation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.qos.ch/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
_______________________________________________
logback-dev mailing list
[email protected]
http://qos.ch/mailman/listinfo/logback-dev
