[
http://jira.qos.ch/browse/LBCLASSIC-22?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=10934#action_10934
]
Maarten Bosteels commented on LBCLASSIC-22:
-------------------------------------------
Great !
Some questions (after a very quick look at the code, and without actually
running it):
* why are locationInfo and properties package private, instead of just private ?
* why are locationInfo and properties default true (in log4j they are deafult
false, because locationInfo does have an impact on performance)
* why use ASCII when one of the advantages of XML is that you can specify an
encoding ?
* I think it would be better to use <![CDATA[ blocks instead of escaping all
non-ASCII characters, remember that XML != HTML,
and AFAIK these escaped characters are NOT valid xml.
> feature request: XMLLayout (cfr. log4j)
> ---------------------------------------
>
> Key: LBCLASSIC-22
> URL: http://jira.qos.ch/browse/LBCLASSIC-22
> Project: logback-classic
> Issue Type: Improvement
> Components: Other
> Affects Versions: unspecified
> Environment: Operating System: Linux
> Platform: PC
> Reporter: dirk
> Assignee: Logback dev list
> Priority: Minor
> Attachments: XMLLayout.jar
>
>
> see Summary
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.qos.ch/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
_______________________________________________
logback-dev mailing list
[email protected]
http://qos.ch/mailman/listinfo/logback-dev
