[ 
http://jira.qos.ch/browse/LBCLASSIC-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11628#action_11628
 ] 

Ceki Gulcu commented on LBCLASSIC-184:
--------------------------------------

The ContextSelectorUtil.java class mostly consists of code moved over from 
StaticLoggerBinder. However, it (ContextSelectorUtil.java) bears a copyright 
notice copied from in your patch bears  the copyright notice "Copyright (c) 
2010 Gunnar Wagenknecht" under the EPL license. This is different than the 
copyright notice in the other logback classes. I suspect that the intent was to 
use the same copyright notice but since a new class was created, your usual 
class creation template kicked in adding your usual copyright notice. 

Assuming the differing copyright notice was unintentional, may I replace 
"Copyright (c) 2010 Gunnar Wagenknecht" in ContextSelectorUtil.java with the 
copyright notice applied to all other logback classes?

> Remove Cyclic Dependencies between Classic, SLF4J API and SLF4J Impl
> --------------------------------------------------------------------
>
>                 Key: LBCLASSIC-184
>                 URL: http://jira.qos.ch/browse/LBCLASSIC-184
>             Project: logback-classic
>          Issue Type: Task
>          Components: Other
>    Affects Versions: 0.9.18
>            Reporter: Gunnar Wagenknecht
>            Assignee: Ceki Gulcu
>            Priority: Critical
>         Attachments: context-selector.patch, mdc-move.patch
>
>
> When working with Logback as OSGi bundles I found some issues regarding 
> cyclic dependencies. Basically, code in "org.slf4j.impl" depends on 
> "org.slf4j.api" as well as Logback classic. This is fine. However, code in 
> Logback classic also depends on "org.slf4j.impl". This introduces a cycle.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.qos.ch/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        
_______________________________________________
logback-dev mailing list
logback-dev@qos.ch
http://qos.ch/mailman/listinfo/logback-dev

Reply via email to