[ 
http://jira.qos.ch/browse/LBCLASSIC-296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12128#action_12128
 ] 

Ceki Gulcu commented on LBCLASSIC-296:
--------------------------------------

Hi Chris,

Let OSGiPackagingDataCalculator be a subclass of  PackagingDataCalculator using 
OSGi class resolution logic. How would you instruct ThrowableProxy to use 
OSGiPackagingDataCalculator ? Via a configuration directive? That would not be 
elegant would it?. 

Couldn't we merge the OSGi specific loging into PackagingDataCalculator ? This 
would introduce a dependency on OSGi but we could make it an optional 
dependency activating the OSGi logic only if the relevant jar was available. As 
an alternative, ThrowableProxy could use OSGiPackagingDataCalculator  in 
presence of osgi platform and PackagingDataCalculator otherwise.

WDYT?

> Allow hook/override in PackagingDataCalculator
> ----------------------------------------------
>
>                 Key: LBCLASSIC-296
>                 URL: http://jira.qos.ch/browse/LBCLASSIC-296
>             Project: logback-classic
>          Issue Type: New Feature
>    Affects Versions: 0.9.29
>            Reporter: Chris Dolan
>            Assignee: Logback dev list
>            Priority: Minor
>         Attachments: PackagingDataCalculator-additions.txt
>
>
> I'm running Logback as my SLF4J implementation in an OSGi container (Karaf). 
> I love the feature of ThrowableProxy that populates stacktraces with the 
> jar/version. Under Karaf, unfortunately, that data is always wrong because 
> Karaf processes the jars into its data/generated-bundles folder before 
> loading.
> So, I forked PackagingDataCalculator in my own code to some class resolution 
> logic (attached). That code is not important because it's too OSGi-specific 
> for inclusion into Logback. But I'd like the ability to inject something like 
> that calculation code into Logback so I don't have to fork 
> PackagingDataCalculator any longer.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.qos.ch/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        
_______________________________________________
logback-dev mailing list
[email protected]
http://qos.ch/mailman/listinfo/logback-dev

Reply via email to