[logback-dev] [JIRA] (LOGBACK-912) ch.qos.logback.core.ContextBase.setStatusManager

Thu, 31 Oct 2013 03:03:19 -0700

Issue Type: Bug Bug
Affects Versions: 1.0.13
Assignee: Logback dev list
Components: logback-core
Created: 31/Oct/13 11:04 AM
Description:

the code is wrong(ch.qos.logback.core.ContextBase.setStatusManager)?
/**

  • Set the {@link StatusManager}

    for this context. Note that by default this

  • context is initialized with a {@link BasicStatusManager}

    . A null value for

  • the 'statusManager' argument is not allowed.
  • <p/>
  • <p> A malicious attacker can set the status manager to a dummy instance,
  • disabling internal error reporting.
    *
  • @param statusManager the new status manager
    */
    public void setStatusManager(StatusManager statusManager) {
    // this method was added in response to http://jira.qos.ch/browse/LBCORE-35
    if (sm == null) { throw new IllegalArgumentException("null StatusManager not allowed"); }
    this.sm = statusManager;
    }


    following right?

    public void setStatusManager(StatusManager statusManager) {
    // this method was added in response to http://jira.qos.ch/browse/LBCORE-35
    if (statusManager == null) { throw new IllegalArgumentException("null StatusManager not allowed"); }

    this.sm = statusManager;
    }
Project: logback
Priority: Minor Minor
Reporter: F.H Dragon
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira 
_______________________________________________
logback-dev mailing list
logback-dev@qos.ch
http://mailman.qos.ch/mailman/listinfo/logback-dev

Reply via email to