[logback-dev] [JIRA] (LOGBACK-940) Sifting appender only removes stale appenders if append() is called

[QOS.CH (JIRA)]

Title: Message Title

Jason Klapste commented on LOGBACK-940   Re: Sifting appender only removes stale appenders if append() is called Before I submit a pull request would you mind looking at for initial thoughts: * https://github.com/jklap/logback/commit/263b9f5e36fceb95cae75692e4ac9e78c06b28f5 Currently the default is to use the executor vs a separate thread-- but I'm wondering if the thread should be the default. If a user configures a sifter without understanding the implication and then creates a large number of sifters we could easily hit the executor pool cap of 8. Note that I'm unhappy with the tests as they require thread sleeps to verify-- suggestions on how to address that would be appreciated. Otherwise ignore the tests I also contemplated moving the cleanup to AppenderTracker. Thoughts? Add Comment   This message was sent by Atlassian JIRA (v7.3.1#73012-sha1:68837e3)

_______________________________________________
logback-dev mailing list
logback-dev@qos.ch
http://mailman.qos.ch/mailman/listinfo/logback-dev