[logback-dev] [JIRA] (LOGBACK-995) Standalone rollover gets exception

QOS.CH (JIRA) Mon, 05 Jun 2017 07:36:32 -0700

Title: Message Title

 
                                                                public class ManualRolloverTest
{
    @BeforeClass
    public static void configureLogback()
    {
        // assume SLF4J is bound to logback in the current environment
        LoggerContext context = (LoggerContext) LoggerFactory.getILoggerFactory();
        try
        {
            JoranConfigurator configurator = new JoranConfigurator();
            configurator.setContext(context);
            // Call context.reset() to clear any previous configuration, e.g. default
            // configuration. For multi-step configuration, omit calling context.reset().
            context.reset();
            String config = "<configuration debug=\"false\" scan=\"false\">\n" +
                            "    <appender name=\"FILE\" class=\"ch.qos.logback.core.rolling.RollingFileAppender\">\n" +
                            "        <file>1.log</file>\n" +
                            "        <rollingPolicy class=\"ch.qos.logback.core.rolling.TimeBasedRollingPolicy\">\n" +
                            "            <!-- daily rollover -->\n" +
                            "            <fileNamePattern>1.log.%d{yyyyMMdd}</fileNamePattern>\n" +
                            "            <maxHistory>3</maxHistory>\n" +
                            "            <totalSizeCap>1GB</totalSizeCap>\n" +
                            "        </rollingPolicy>\n" +
                            "    </appender>\n" +
                            "    <root level=\"INFO\">\n" +
                            "        <appender-ref ref=\"FILE\" />\n" +
                            "    </root>\n" +
                            "</configuration>";
            configurator.doConfigure(new ByteArrayInputStream(config.getBytes()));
        }
        catch (JoranException je)
        {
            // StatusPrinter will handle this
        }
        StatusPrinter.printInCaseOfErrorsOrWarnings(context);
    }

    @Test
    public void checkManualRolloverDoesNotThrowNPE() throws Exception
    {

        // assume SLF4J is bound to logback in the current environment
        LoggerContext loggerContext = (LoggerContext) LoggerFactory.getILoggerFactory();

        Logger logger = loggerContext.getLogger(org.slf4j.Logger.ROOT_LOGGER_NAME);
        rollover(logger.iteratorForAppenders());
    }

    private static void rollover(Iterator<Appender<ILoggingEvent>> it)
    {
        for (; it.hasNext(); )
        {
            Appender<ILoggingEvent> appender = it.next();
            if (appender instanceof RollingFileAppender)
            {
                RollingFileAppender rollingFileAppender = (RollingFileAppender) appender;
                rollingFileAppender.rollover();
            }
            else if (appender instanceof AsyncAppender)
            {
                AsyncAppender asyncAppender = (AsyncAppender) appender;
                rollover(asyncAppender.iteratorForAppenders());
            }
        }
    }
}

 
                                                            

Here is the unit test.

The issue is that

TimeBasedFileNamingAndTriggeringPolicyBase.elapsedPeriodsFileName is null at startup time until DefaultTimeBasedFileNamingAndTriggeringPolicy.isTriggeringEvent is called at least once.

I'm not aware with logback architecture good enough to provide a patch, but it could be as simple as doing

elapsedPeriodsFileName = tbrp.fileNamePatternWithoutCompSuffix.convert(getCurrentTime());

in start() method.

Add Comment

This message was sent by Atlassian JIRA

_______________________________________________
logback-dev mailing list
logback-dev@qos.ch
http://mailman.qos.ch/mailman/listinfo/logback-dev

[logback-dev] [JIRA] (LOGBACK-995) Standalone rollover gets exception

Reply via email to