Thanks for merging these PR! It looks like the end result is a mix of PR 305 and PR 534. The initial PR 305 was calling the parameter "disableHostnameVerification", with the implication it would be enabled by default when nothing was set. PR 534 called it "enabledHostnameVerification", but used Boolean.TRUE as its default value. As I've just commented on PR 305, it seems that the latest patch simply calls the parameter "hostnameVerification", but the default value is null the verification settings would not be called at all unless users set it explicitly to true. Obviously, it's design choice and there's no right or wrong, but I think this security setting should be enabled by default, otherwise the vulnerability is still effectively present unless users have actively enabled that parameter. |