OK. So if we're playing the p5p drinking game,
what and how much do we drink when Ilya sends six messages in a burst?
Do we drink extra because none are part of any existing thread?
Do we drink extra because all six contain patches?
De we drink extra for each that contains comments? Or do we drink extra
for each that doesn't? [This is perhaps the hardest question]

Nicholas Clark
----- Forwarded message from Ilya Zakharevich <[EMAIL PROTECTED]> -----

Mailing-List: contact [EMAIL PROTECTED]; run by ezmlm
Precedence: bulk
list-help: <mailto:[EMAIL PROTECTED]>
list-unsubscribe: <mailto:[EMAIL PROTECTED]>
list-post: <mailto:[EMAIL PROTECTED]>
Delivered-To: mailing list [EMAIL PROTECTED]
Date: Sat, 19 May 2001 04:35:28 -0400
From: Ilya Zakharevich <[EMAIL PROTECTED]>
To: Mailing list Perl5 <[EMAIL PROTECTED]>
Subject: [PATCH 5.6.1] build bugs OS/2
User-Agent: Mutt/1.2.5i
X-Spam-Rating: onion.valueclick.com 1.6.2 0/1000/N

Two tiny fixes:

  a) a wrong version of Perl could be lifted for the installer;

  b) an embarassing misprint leading to a segfault;

Enjoy,
Ilya

--- ./os2/Makefile.SHs-pre      Tue May  8 02:27:22 2001
+++ ./os2/Makefile.SHs  Tue May  8 02:55:12 2001
@@ -154,8 +154,8 @@ perl_sys: $& perlmain$(OBJ_EXT) $(LIBPER
        $(SHRPENV) $(CC) $(SYS_CLDFLAGS) $(CCDLFLAGS) -o perl_sys perlmain$(OBJ_EXT) 
$(DYNALOADER) $(static_ext) $(LIBPERL) `cat ext.libs` $(libs)
 
 installcmd : 
-       perl -e 'die qq{Give the option INSTALLCMDDIR=... to make!} if $$ARGV[0] eq 
""' $(INSTALLCMDDIR)
-       perl os2/perl2cmd.pl $(INSTALLCMDDIR)
+       @perl -e 'die qq{Give the option INSTALLCMDDIR=... to make!} if $$ARGV[0] eq 
+""' $(INSTALLCMDDIR)
+       ./miniperl -Ilib os2/perl2cmd.pl $(INSTALLCMDDIR)
 
 # Aout section:
 
--- ./os2/os2.c-pre-fcn Tue May  8 02:27:22 2001
+++ ./os2/os2.c Wed May  9 03:07:38 2001
@@ -203,18 +203,15 @@ loadByOrd(char *modname, ULONG ord)
 {
     if (ExtFCN[ord] == NULL) {
        static HMODULE hdosc = 0;
-       BYTE buf[20];
-       PFN fcn;
+       PFN fcn = (PFN)-1;
        APIRET rc;
 
-       
-       if (!hdosc) {
+       if (!hdosc)
            hdosc = loadModule(modname);
-           if (CheckOSError(DosQueryProcAddr(hdosc, loadOrd[ord], NULL, &fcn)))
-               Perl_croak_nocontext(
+       if (CheckOSError(DosQueryProcAddr(hdosc, loadOrd[ord], NULL, &fcn)))
+           Perl_croak_nocontext(
                        "This version of OS/2 does not support %s.%i", 
                        modname, loadOrd[ord]);     
-       }
        ExtFCN[ord] = fcn;
     } 
     if ((long)ExtFCN[ord] == -1) 

----- End forwarded message -----

Reply via email to