On Thu, 26 Mar 2026 09:09:11 GMT, Francesco Nigro <[email protected]> wrote:

> Ported from 7ac9ca128885c5dd561e6fbd6bbeaddb86d6264c to the latest upstream 
> fibers branch. Adapted to the current API which renamed 
> implRegister/implDeregister to implStartPoll/implStopPoll and added 
> Mode/EventFD/Cleaner/PollerGroup architecture.

Just an FYI that we've been experiments with epoll edge triggered mode in the 
past. The main concerns were that it's very fragile (only works with specific 
usage patterns) and adds complexity by way of book keeping. Yes, it can reduce 
the need to re-arm a file descriptor but overall it was never clear if 
significant benefits could be proving in real world cases to justify the 
complexity.

I'm not opposed to trying again but I think this require creating a new branch 
and iterating there. Would you be okay with that?

I think it would be useful to know what testing has been done so far. I did 
some quick testing and see failures/timeouts with HTTP3 tests which seems to be 
UDP or selection ops in the context of a virtual thread. I think it would also 
be useful to see some benchmark data.

-------------

PR Comment: https://git.openjdk.org/loom/pull/223#issuecomment-4135504793

Reply via email to