R?my-Christophe Schermesser wrote: > Hi, > > I have tried to merge the methods /synchronizeDb2Ldap/ and > /synchronizeLdap2Ldap /into one method. These two methods are at 90% the > same, so I merged them into one. > > I will try do to the same with /cleanDb2Ldap/ and/ cleanLdap2Ldap./ > > I have tested this new method with a Ldap2Ldap sync and it works ! > > What do you think you this merge ?
I had a look through your patch. Looks OK to me, a few comments: - it really needs to be testes with a db2ldap sync - you need to make sure the old synchronize*2ldap() methods rewrap to the new synchronize2ldap and are marked deprecated - the name "LscObject" for the superior class to "top" and "fTop" surprises me. But I can't think of anything better... S?bastien is the original author of the flat/fTop/etc code. What is your opinion on this, S?b? Jon
