Hi, 2008/11/26 Sebastien Bahloul <sbahloul at linagora.com>
> Hi Remy-Christophe, > > While looking at your patch, I have some global questions / notices : > > 1/ Your first patch section is about converting a test to a exception and I > ask if this is really a good practice : I thought that exceptions must not > be > used to manage a "normal" case, but only if something unattended occurs. Yes that is not a very good idear, but I used built-in fonctions of the enum in Java. So less code ! > > > 2/ I just give a quick look, but it seems to me that it is not possible to > launch in the same process a sync task followed by the corresponding clean > task. Am I wrong or is there a work arround ? Yes you are right, sorry for the mistake. I modified the patch to integrate it. > > > But aftere all, this is really a good thing you joined the LSC community to > provide us a developper point of vue :) Thanks for the welcome ;) Rcs > > > Thanks, > > Le mardi 25 novembre 2008, R?my-Christophe Schermesser a ?crit : > > Hi, > > > > Here is another simplification of the code for launching tasks. > > > > What do you think of this patch ? > > > > Cheers, > > > > Rcs > > > > -- > Sebastien BAHLOUL > LinRun (OSSA, Hosting) and LinID Manager > LINAGORA : http://www.linagora.com/ > Tel / Phone : +33 (0)1 58 18 68 28 > Mobile : +33 (0)6 45 63 27 39 > ----------- > Ldap Synchronization Connector : http://lsc-project.org/ > FederID : http://www.federid.org/ > Open Source projects for identities management and federation > -- "In a world without walls and fences, who needs windows and gates ?" -- Tosca : A 2.0 bugtracker : http://www.tosca-project.net -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.lsc-project.org/pipermail/lsc-dev/attachments/20081126/eb1768a6/attachment-0001.htm -------------- next part -------------- A non-text attachment was scrubbed... Name: simplificationLauchTasks.diff Type: application/octet-stream Size: 11947 bytes Desc: not available Url : http://lists.lsc-project.org/pipermail/lsc-dev/attachments/20081126/eb1768a6/attachment-0001.obj
