Issue #205 has been updated by Stéfanie Duprey. File patch_samba_passwords.diff added
Jonathan Clarke wrote: > Sébastien Bahloul wrote: > > The following patch is provided by Stefanie Duprey ([email protected]). > > It is based on JCifs library (http://jcifs.samba.org) which is under the > > LGPL license. Any issue about including this library before putting this > > code in the trunk ? > > This is an interesting feature for LSC, in my opinion. Thanks for working on > a patch! I do have some comments: > > 1) I think there are some minor issues when linking BSD code to LGPL code, > but I'm not sure. However, including LGPL licensed code directly in a BSD > licensed source file is clearly not allowed. This is the case for your method > "E" in the proposed patch. > > I'm sorry if I seem difficult, but it is important for the LSC project to > respect free software licenses and their implications. LSC is under the BSD > license, and any contributions should also be under this license, unless they > are clearly separated and could be included in a separate repository... > > However, are there no BSD-compatible implementations of the MD4 and DES > algorithms? The "E" method seems pretty simple, surely others have > implemented this many times before, and it shouldn't be an issue? > > I have no objection to include a similar patch to LSC, once license problems > have been resolved - as I said, it would be a nice feature. However, I must > object to this current patch, as is. But I'm sure we can work something out! > > 2) I'm a bit curious as to why computeNTPassword returns "lmHash" and > computeLMPassword returns "ntHash". It would be a good thing to have a simple > JUnit test to make sure these methods do what they should. > > Regards, > Jonathan For the second point, Sebastien posted the patch whereas I didn't remember to told him I had made a mistake : I inversed the name of the two methods... So the right patch is in attachment, with a JUnit test. For the first point, I'm not an expert in encryption so all I can do is rewriting the method, and I don't agree with copy somebody's work omitting to notice that it's not my work. What should we do so ? ---------------------------------------- Feature #205: Add support for lm/ntPassword encryption http://tools.lsc-project.org/issues/show/205 Author: Sébastien Bahloul Status: New Priority: Normal Assigned to: Sébastien Bahloul Category: Core Target version: 1.3 branch In order to put encrypted password inside smbLMPassword and smbNTPassword attributes, it is necessary to add support for the corresponding encryption schema -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://tools.lsc-project.org/my/account
_______________________________________________________________ Ldap Synchronization Connector (LSC) - http://lsc-project.org lsc-dev mailing list [email protected] http://lists.lsc-project.org/listinfo/lsc-dev
