Issue #213 has been updated by Jonathan Clarke.

Hi,

OK, I see the difference with #206, thanks.

I've just looked through this code, and submitted a patch for various details 
(documentation, duplicated code, logging, etc). A few questions come to mind:
# All the public methods are static, and call getInstance(). Shouldn's this 
method be private, to avoid it being called by users?
# This only operates on the destination directory only! What if we want to 
read/write to the source instead? (or, one day, to any connector...)

I see various approaches to enable this: either have this class as an extension 
to JndiServices, so you can write srcLdap.getCurrentValue(dn, attrName), OR 
change the methods to accept a JndiServices object (or a Service object?) that 
you can call .apply(jm) on. Or something else?

Thoughts?

----------------------------------------
Feature #213: Adding a sequence handling 
http://tools.lsc-project.org/issues/213

Author: Sébastien Bahloul
Status: Assigned
Priority: Normal
Assigned to: Sébastien Bahloul
Category: Core
Target version: 1.3.x branch


Samba requires a dedicated entry that handle the next available uid / gid 
number.

Look for sambaUnixIdPool keyword in 
http://www.samba.org/samba/docs/man/Samba-HOWTO-Collection/upgrading-to-3.0.html


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://tools.lsc-project.org/my/account
_______________________________________________________________
Ldap Synchronization Connector (LSC) - http://lsc-project.org

lsc-dev mailing list
[email protected]
http://lists.lsc-project.org/listinfo/lsc-dev

Reply via email to