Issue #20 has been updated by Rémy-Christophe Schermesser.
First of all, great Job ! The code is quite clear, and I like the Task object
which simplifies SimpleSynchronize !
I have some minor comments :
* Where are the tests ? :)
* Why did you create the class src/main/java/org/lsc/MapEntry.java ?
* In src/main/java/org/lsc/AbstractSynchronize.java
** You should no write that LOGGER.error("Tasks terminated according to time
limit: " + e.toString(), e) but : LOGGER.error("Tasks terminated according to
time limit"); LOGGER.debug(e.toString(), e);
** Try not to concatenate constants Strings (line 331)
* I think the class src/main/java/org/lsc/Task.java should be in the
org.lsc.configuration packagen, what do you think ?
* In src/main/java/org/lsc/jmx/LscAgent.java :
** Why did you wrote System.out.println/error ?
** The line LOGGER.error("Unknown attribute name=value couple in \"" + token +
"\". Please check your parameters !") should be replace by something like that
: LOGGER.error("Unknown attribute name=value couple in \"{}\". Please check
your parameters !", token); (There are more lines like that)
* In src/main/java/org/lsc/SimpleSynchronize.java
** You should not use keySet but entrySet (line 141) and pleaaaaaaaaaaaaase do
not use Iterators if you can, it is very very awful
----------------------------------------
Feature #20: Daemon mode for continuous synchronization
http://tools.lsc-project.org/issues/20
Author: Jonathan Clarke
Status: New
Priority: Normal
Assigned to:
Category:
Target version: Sometime in the future
This would be nice, one day.
--
You have received this notification because you have either subscribed to it,
or are involved in it.
To change your notification preferences, please click here:
http://tools.lsc-project.org/my/account
_______________________________________________________________
Ldap Synchronization Connector (LSC) - http://lsc-project.org
lsc-dev mailing list
[email protected]
http://lists.lsc-project.org/listinfo/lsc-dev
