Issue #105 has been updated by Jonathan Clarke.
Sébastien Bahloul wrote: > Here is the diff. A feedback is required because it implies lots of classes > modification and breaks some compatibilities :P Thanks to some free time at RMLL in Bordeaux, I took a look at this patch with Seb :) Some comments: * The patch is very clear, and I agree with almost all of it :) * The new class LscModifications stores a "main ID" which is the inheritance of "DN" from JndiModifications. I don't think that this is a general notion for all data repositories (having a DN to identify entries is very LDAP specific). * Careful with unrelated changes! Like logging messages, etc :) * I think you can s/Set<Entry<A,B>>/Map<A,B>/ :) Suggestions: * We should rename the "main ID" in LscModifications to be a "display name" to identify entries in logs (just a string, which might be the DN for LDAP related connectors but not necessarily) * JNDI based connectors should manage the DN just like any other attribute. The fact that changing the DN requires a seperate operation (MODRDN) should be hidden in the JNDI connectors. I'll open a new feature request for this. * It would be nice to store old values in LscAttributeModification, to see what we're replacing. This is necessary for treating the DN like other attributes for JNDI connectors (to detect when to do a MODRDN). ---------------------------------------- Feature #105: Rework all code to be independant of src/dst type http://tools.lsc-project.org/issues/105 Author: Jonathan Clarke Status: Assigned Priority: Normal Assigned to: Sébastien Bahloul Category: Core Target version: 1.3.x branch Change central methods to work with srcBean and dstBean, regardless of where they came from/are going to. This includes returning modifications in a generic way, not JndiModifications. This would be a good start to enable several cool features afterwards, including: * Multiple sources/destinations * Synchronizing to a DB -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://tools.lsc-project.org/my/account
_______________________________________________________________ Ldap Synchronization Connector (LSC) - http://lsc-project.org lsc-dev mailing list [email protected] http://lists.lsc-project.org/listinfo/lsc-dev
