Issue #519 has been updated by Raphaël Ouazana.

Status changed from Assigned to Closed
% Done changed from 0 to 100

Thank you. Patch applied, with similar corrections for SyncreplSourceService 
(based on Apache Directory API).
Note that synchronization of binary attributes still doesn't work, see #533.
----------------------------------------
Bug #519: User-specified binary attributes do not function
http://tools.lsc-project.org/issues/519

Author: Alex A
Status: Closed
Priority: High
Assigned to: Raphaël Ouazana
Category: Core
Target version: 2.0.1
Problem in version: 2.0


There are two typos in JndiServices.java, line 392, one which prevents 
user-specified binary attributes from functioning at all, and the other which 
doesn't properly delimit multiple user-specified attributes. See below:

<pre>
if(connection.getBinaryAttributes() != null) {
  props.setProperty("java.naming.ldap.binaryAttributes", 
StringUtils.join(connection.getBinaryAttributes().getString(), ", "));
}
</pre>

This property being set should be "java.naming.ldap.attributes.binary", not 
"java.naming.ldap.binaryAttributes".
Also, the join needs to be " " (space), not ", "(comma space), because it takes 
a space delimited list, not a comma delimited list.

The above section should read:
<pre>
if(connection.getBinaryAttributes() != null) {
  props.setProperty("java.naming.ldap.attributes.binary", 
StringUtils.join(connection.getBinaryAttributes().getString(), " "));
}
</pre>

This bug causes serious issues for folks trying to read binary objects, such as 
objectSid, or objectGuid from AD.

Refrences:
http://docs.oracle.com/javase/jndi/tutorial/ldap/misc/attrs.html
"env.put("java.naming.ldap.attributes.binary", "mpegVideo mySpecialKey");"



-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://tools.lsc-project.org/my/account
_______________________________________________________________
Ldap Synchronization Connector (LSC) - http://lsc-project.org

lsc-dev mailing list
[email protected]
http://lists.lsc-project.org/listinfo/lsc-dev

Reply via email to