Issue #672 has been reported by Italo Valcy.
----------------------------------------
Bug #672: Log level from etc/logback.xml is not been used by some functions
http://tools.lsc-project.org/issues/672
Author: Italo Valcy
Status: New
Priority: Normal
Assigned to:
Category:
Target version:
Problem in version:
Hello Guys,
I'm using LSC to synchronize from one LDAP directory to another and it is
working perfectly. My only problem is that I wanna configure logging level to
only output to CONSOLE and only above level WARN. My etc/logback.xml looks like
the following:
<pre>
<?xml version="1.0" encoding="UTF-8"?>
<configuration>
<appender name="CONSOLE" class="ch.qos.logback.core.ConsoleAppender">
<encoder
class="ch.qos.logback.core.encoder.LayoutWrappingEncoder">
<layout class="org.lsc.utils.output.LdifLayout">
<Pattern>%date{MMM dd HH:mm:ss} - %-5level -
%message%n</Pattern>
</layout>
</encoder>
</appender>
<logger name="org.lsc" level="WARN">
<appender-ref ref="CONSOLE"/>
</logger>
<!--
<root level="WARN">
<appender-ref ref="CONSOLE"/>
</root>
-->
</configuration>
</pre>
However, when I run LSC, I got the following:
<pre>
./bin/lsc -f etc/ -s XYZTask -c XYZTask
Mar 08 14:48:11 - DEBUG - Loading XML configuration from:
/usr/local/share/lsc/etc/lsc.xml
Mar 08 14:48:11 - INFO - Reflections took 129 ms to scan 1 urls, producing 52
keys and 104 values
Mar 08 14:48:11 - DEBUG - Importing XML schema file: schemas/lsc-core-2.0.xsd
...
</pre>
Looking at the source code, seems like some java classes dont use the "final"
keyword when declaring LOGGER variable. This way, the configuration done at
etc/logback seems to be overwritten. Bellow is proposed patch to fix this issue
(from svn trunk):
<pre>
Index: src/main/java/org/lsc/connectors/xmlrpc/AbstractLscXmlRpcClient.java
===================================================================
--- src/main/java/org/lsc/connectors/xmlrpc/AbstractLscXmlRpcClient.java
(revision 1932)
+++ src/main/java/org/lsc/connectors/xmlrpc/AbstractLscXmlRpcClient.java
(working copy)
@@ -66,7 +66,7 @@
*/
public abstract class AbstractLscXmlRpcClient extends AbstractLscXmlRpcObject {
- private static Logger LOGGER =
LoggerFactory.getLogger(AbstractLscXmlRpcClient.class);
+ private static final Logger LOGGER =
LoggerFactory.getLogger(AbstractLscXmlRpcClient.class);
private URL url;
private String username;
Index: src/main/java/org/lsc/utils/ScriptingEvaluator.java
===================================================================
--- src/main/java/org/lsc/utils/ScriptingEvaluator.java (revision 1932)
+++ src/main/java/org/lsc/utils/ScriptingEvaluator.java (working copy)
@@ -15,7 +15,7 @@
public class ScriptingEvaluator {
- private static Logger LOGGER =
LoggerFactory.getLogger(ScriptingEvaluator.class);
+ private static final Logger LOGGER =
LoggerFactory.getLogger(ScriptingEvaluator.class);
/**
* The instances, one per thread to protect non thread safe engines like
Index: src/main/java/org/lsc/configuration/JaxbXmlConfigurationHelper.java
===================================================================
--- src/main/java/org/lsc/configuration/JaxbXmlConfigurationHelper.java
(revision 1932)
+++ src/main/java/org/lsc/configuration/JaxbXmlConfigurationHelper.java
(working copy)
@@ -89,7 +89,7 @@
public static final String LSC_NAMESPACE =
"http://lsc-project.org/XSD/lsc-core-2.0.xsd";;
private JAXBContext jaxbc;
- private static Logger LOGGER =
LoggerFactory.getLogger(JaxbXmlConfigurationHelper.class);
+ private static final Logger LOGGER =
LoggerFactory.getLogger(JaxbXmlConfigurationHelper.class);
/**
* Initiate helper by adding XML aliases
</pre>
Thanks for any help.
Regards, Italo.
--
You have received this notification because you have either subscribed to it,
or are involved in it.
To change your notification preferences, please click here:
http://tools.lsc-project.org/my/account
_______________________________________________________________
Ldap Synchronization Connector (LSC) - http://lsc-project.org
lsc-dev mailing list
[email protected]
http://lists.lsc-project.org/listinfo/lsc-dev
