Le 06/03/2017 à 10:36, Soisik Froger a écrit :
Hi,



Hello Soisik,


Conclusion :
- I could reproduce OutOfMemory exception, the "missed" entries issue, and NullPointerException and I could make sure that PR fixes these 3 issues.

Great!

- I can confirm that the PR have no impact on LSC performances in this specific test case (LSC performances seem to depend on the underlying data store capacity to apply modification orders, rather than the amount of simultaneous threads processing orders)


Ok.

Though, I'd like to investigate further LSC performances with large entries :

* I do not know why the more entries are synchronized, the longer it takes. After 5000 entries, the drop in performances is noticeable/exponential. In a perfect world, you'd expect that 50 000 would be processed in 10x the time it took for 5000, which would be 22 minutes. Is OpenDJ become slower to respond as it's growing in size ? Or we got some kind of internal memory leaks? I'd like to find out.



Indeed, we should have a very linear behavior here.

* It seems that each sync task opens a jndi connection to the data store and closes it when it's done. If confirmed, I think it would be cleaner and more efficient to use a pool of connections.

No idea about this, but I though tha to JNDI connections were linked to LSC threads.


I also found an old discussion about LSC thread pool: http://tools.lsc-project.org/issues/742, I don't know if this confirm what you done in your PR.




====

@Clement : I'd like to push this JMH benchmark project in a new repository "lsc-benchmark" in lsc-project with the test case. Can I just process with it ? I'll add a readme.md file that explain how to run it. There is one issue I still need to dig; LSC logs do not display while processing.


Yes, project created: https://github.com/lsc-project/lsc-benchmark

You can push your code.



Clément.
_______________________________________________________________
Ldap Synchronization Connector (LSC) - http://lsc-project.org

lsc-dev mailing list
[email protected]
https://lists.lsc-project.org/cgi-bin/mailman/listinfo/lsc-dev

Reply via email to